Repository navigation
Camera popup look: live badge, full-bleed media, inline buttons - #71
Merged
mhoogenbosch merged 1 commit intoOct 14, 2026
Merged
Conversation
Options for a modern TV camera notification, each off by default: - liveBadge: a "Live" pill over the stream once the first frame renders (never over the poster); liveBadgeColor (default amber) and liveBadgePosition (any corner, default bottom right). - mediaFullBleed: the video or image runs edge to edge across the top, its top corners clipped to the popup's corner radius; title, message and buttons keep the padding, in a compact text block. - buttonsInline: buttons at the end of the title/message row instead of a row of their own, e.g. a single compact close button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
davbebawy
pushed a commit
to davbebawy/PiPup
that referenced
this pull request
Oct 30, 2026
…angelog for mhoogenbosch#69-mhoogenbosch#71 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three opt-in options for a modern TV camera notification (the kind where the camera fills the top of the card, with a "Live" pill on the video and compact text underneath). Each is off by default; nothing changes for existing popups.
(full screen)
liveBadge: a "Live" pill over the stream area that appears on the first rendered frame, so it never sits on the poster. It covers all stream types that use the shared poster/first-frame path (video_url/camera stream, WHEP, web).liveBadgeColordefaults to amber#FFA500(parsed withparseColorOrDefault), andliveBadgePositiontakestop_left/top_right/bottom_left/bottom_right(default).mediaFullBleed: the media frame runs edge to edge across the top. The popup keeps only its border inset, the frame's top corners are clipped to the popup's corner radius (ViewOutlineProvider), and the title, message and button rows carry the padding. The text block under the media is compact: a smaller gap and no extra font padding.buttonsInline: buttons sit at the end of the title/message row instead of a row of their own. That's handy for a single compact close button (label: "✕"), and pairs well with the button style options in Make popup button colors and corner radius configurable #70.Tests:
LiveBadgeTest(defaults, color, corner mapping) andMediaFullBleedTest(defaults). The suite passes.Tested on an onn 4K Streaming Box (Android 14): a
camera_entitystream popup with all three options plus #69/#70, as in the screenshot.The ha-pipup side: mhoogenbosch/ha-pipup#44.
🤖 Generated with Claude Code