Repository navigation
0.28.0: camera popup look, button style, video height (#69, #70, #71) - #72
Merged
Merged
Conversation
A camera_entity popup sized its stream area from the poster's pixel size until the first frame. NVR snapshots are often anamorphic (704x480 for a 4:3 picture), so the poster showed too short and the box jumped when the stream reported its display aspect. An optional media.video height now fixes the box until then; without it nothing changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Buttons always used a bright blue focus fill with a white outline, which clashes with a styled popup. New optional props buttonColor, buttonFocusColor, buttonTextColor, buttonBorderColor and buttonCornerRadius override each part; unset fields keep the classic look. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Options for a modern TV camera notification, each off by default: - liveBadge: a "Live" pill over the stream once the first frame renders (never over the poster); liveBadgeColor (default amber) and liveBadgePosition (any corner, default bottom right). - mediaFullBleed: the video or image runs edge to edge across the top, its top corners clipped to the popup's corner radius; title, message and buttons keep the padding, in a compact text block. - buttonsInline: buttons at the end of the title/message row instead of a row of their own, e.g. a single compact close button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # app/src/main/java/nl/rogro82/pipup/PopupView.kt
# Conflicts: # app/src/main/java/nl/rogro82/pipup/PopupView.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates @pelkiegr's #69, #70 and #71 for 0.28.0, with their commits kept as-is through merge commits, so those PRs show as merged.
height(poster box) was a fast-forward. Make popup button colors and corner radius configurable #70 button style and Camera popup look: live badge, full-bleed media, inline buttons #71 camera popup look conflicted only at the end ofPopupView.kt, where each appends a top-level helper. Both sides are kept.buttonsInlineon a media-only popup (no title/message/icon). The header row is removed in that case, so the inline buttons went into a detached view and never showed. They now fall back to their own row.Closes #69, closes #70, closes #71.
🤖 Generated with Claude Code