Repository navigation
Conversation
A camera_entity popup sized its stream area from the poster's pixel size until the first frame. NVR snapshots are often anamorphic (704x480 for a 4:3 picture), so the poster showed too short and the box jumped when the stream reported its display aspect. An optional media.video height now fixes the box until then; without it nothing changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 14, 2026
Owner
|
Merged via #72, together with #70 and #71: your commit is in master as-is, GitHub just marks this one "closed" because it went in as a fast-forward. Released in v0.28.0, with ha-pipup 1.27.0. Thanks for all three! One fix on top, in #72: |
davbebawy
pushed a commit
to davbebawy/PiPup
that referenced
this pull request
Oct 30, 2026
…angelog for mhoogenbosch#69-mhoogenbosch#71 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #67, as discussed there.
Problem: a
camera_entitypopup sizes its stream area from the poster's pixel size until the first frame. NVR snapshots are often anamorphic: my LaView/Hikvision NVR serves a 704×480 still of a 4:3 picture, and its substream is 640×360 with SAR 3:4. The poster therefore shows at 640×436 and the box jumps to 640×480 when #67's display-aspect sizing kicks in. JFIF in the snapshot says 1:1, so the app can't detect it from the image.Fix:
media.videotakes an optionalheight. When set, the provisional box and the poster use it until the first frame, and the poster no longer overrides it. When it's absent, behavior is unchanged: 16:9 provisional, then the poster's aspect. Small pure helpers (provisionalVideoHeight,posterVideoHeight) withVideoPosterHeightTest(5 cases).Tested: onn 4K Streaming Box (Android 14). With
height: 480the poster and live video now line up with no jump.The ha-pipup side sends it from
media_height: mhoogenbosch/ha-pipup#42.🤖 Generated with Claude Code