Skip to content

feat(mobile): rebuild Settings, Machines, terminal, Files and preview natively (native overhaul 3/4) - #7838

Merged
Prasad-D-Ware merged 5 commits into
mobile-native-overhaul/02from
mobile-native-overhaul/03
Nov 6, 2026
Merged

Prasad-D-Ware merged 5 commits into
mobile-native-overhaul/02from
mobile-native-overhaul/03

Conversation

@MohamedKamran

@MohamedKamran MohamedKamran commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Code changes: +5682 -3093
Tests: +4255 -531
Others: +0 -0

Important

Stacked PR 3 of 4: the mobile native overhaul, split from #7419. Merge in order:

Order PR Contents
1 #7836 Native toolchain: dependencies, patches, config plugins, assets
2 #7837 New building blocks (nothing imports them yet)
3 #7838 ← this PR Settings, Machines, terminal, Files and preview
4 #7839 Native tabs, board, New task, chat, old-code removal

Base: mobile-native-overhaul/02 (#7837). The diff shows only this PR's changes.

Do not merge until #7837 has merged. Once it has, this PR retargets to main (or run gh pr edit 7838 --base main); then wait for CI and merge.

How to merge: use Create a merge commit (each commit here builds on its own). Then delete mobile-native-overhaul/03 so #7839 retargets.

Merge #7839 soon after this one, and don't cut a mobile release between them. Until #7839 lands, these screens sit beside the old board and chat.

What

Settings, Machines, pairing and onboarding, the terminal, Files and preview, rebuilt on native controls. Five commits:

  1. Shared tokens, theme fields and controls the screens use.
    • Additions only; no existing value changes:
      • stateOpacity, rowIconWidth and onCamera tokens and the theme's onDestructive;
      • press feedback, the Compose grouped list, composer field sizing and connectRoute;
      • a tonal secondary Button with system-symbol icons, and a busy EmptyState.
    • Machines draw as system symbols everywhere.
  2. Settings, Machines, pairing and onboarding.
    • Settings becomes a SwiftUI Form on iOS and an M3 list on Android, led by the account.
    • Machines are listed in Settings, and each opens its own machine page.
    • Pairing is a page with a header, and Manual connect is a page pushed over it.
    • Onboarding is a picture, one line and Connect.
    • The Environments page is removed, and Android plays the system's own haptics.
  3. Terminal. Native header items and platform notices, an input bar that matches the chat composer with a Chat/Terminal switch, native-sized symbol keys and scroll-to-top.
  4. Files.
    • Folders open as pages, with search in the header and segmented controls.
    • Viewer controls move into header items, images zoom on both platforms and diffs open in the viewer.
    • The artifact page uses the new review button.
  5. Preview. Native browser controls with reload, progress and history, a header menu to pick the view, and gesture-handler pan and pinch.

Why

These screens depend only on the shared pieces in commit 1, not on the new navigation or on each other. So they can land before #7839, which carries the navigation switch and the board and chat.

Before / After

Before After
Settings: drawn list with a separate Environments page Native Form (iOS) / M3 list (Android), led by the account, machines listed in place
Pairing opens as a modal without a header Pairing is a page titled "Pair a machine"; "Connect manually" is pushed over it
Machine icons drawn with Feather/SVG Drawn as SF Symbols / Material Symbols
Terminal: drawn header controls and composer Native header items; input bar matches chat's composer
Files: one list with drawn controls Folders as pages, header search, native segmented controls, zoomable images
Preview: drawn browser controls Native reload, progress, history and view menu

Screenshots of each screen on iOS and Android will be added from a simulator run.

How

This PR adds a little code that never existed on #7419. It lets these screens run while the board and chat are still the old ones, and #7839 replaces all of it with the final versions:

  • Shared files: only additions to tokens, theme, themeDerive, ui, chat/composerStyles and sheetResult. Today's screens render exactly as before.
  • Machine helpers: MachineGlyph and sharedMachineSymbols stay, for the current Workers filter.
  • Root layout: registers pairing (now a page), the connect page, the Files folder page and the Files review sheet.
  • Tests: a few existing tests are updated to match the in-between state: route lists, machine glyphs drawn by AppSymbol, and font and haptics mocks.

Reviewer focus:

  • The commit-1 additions to ui.tsx. Existing Feather icon names still draw with Feather.
  • How these screens look beside the old board and chat.

Testing

  • Every commit typechecks and passes the full suite on its own: 2,973 → 3,097 → 3,138 → 3,157 → 3,185 tests.
  • At the tip: npm run typecheck passes, and npm test passes 333 files and 3,185 tests.
  • Not done yet:
    • simulator runs on iOS and Android;
    • in particular, pairing opened from onboarding and from the Workers "Scan" button.

Checklist

  • Branched from main (or continuing an existing PR branch)
  • One focused change; links the related issue when applicable
  • Follows AGENTS.md conventions and PR hygiene
  • Before / After filled in; UI changes include screenshots or a recording
  • Tests added/updated for user-visible behavior where it makes sense
  • Relevant CI checks pass for the area touched (go, frontend, etc.)

🤖 Generated with Claude Code

@MohamedKamran
MohamedKamran marked this pull request as ready for review November 5, 2026 15:06
MohamedKamran added a commit that referenced this pull request Nov 5, 2026
This branch (#7419) was too large to review: 354 commits and 858 files. Its
history couldn't be split by cherry-picking. Most commits fix earlier ones,
and a few commits touch hundreds of files across every area.

So the split was rebuilt from this branch's final code, merged with current
main, as a stack of four PRs. Each one typechecks and passes the full mobile
suite on top of the one below it:

1. #7836 mobile-native-overhaul/01: native toolchain, config plugins and
   assets (dependencies, patches, plugins, icons, fonts).
2. #7837 mobile-native-overhaul/02: 180 new building-block files that nothing
   on main imports yet.
3. #7838 mobile-native-overhaul/03: Settings, Machines, pairing, onboarding,
   terminal, Files and preview, rebuilt natively.
4. #7839 mobile-native-overhaul/04: native tabs, the shared restyle, Workers,
   Projects and Pull Requests, New task, chat, and removal of the old code.

Merge them in order, using merge commits for 1-3 and a squash for 4. After
each merge, retarget the next PR to main. The tip of #7839 is identical to
this branch merged with main, so main ends up with exactly this work.

#7838 carries a little bridging code that never existed here. It adds new
tokens, theme fields and ui props, keeps MachineGlyph and
sharedMachineSymbols, registers its new routes in the root layout, and
updates a few tests for the in-between state. It lets those screens run
beside the old board and chat until #7839 replaces it with this branch's
versions.

This commit changes no files. This branch and #7419 stay as the reference;
close #7419 once #7839 merges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🏆 Review leaderboard

Oct 29, 2026–Nov 5, 2026 · UTC

Rank Reviewer PRs reviewed Review rounds PR comments
🥇 @ronishrohan @ronishrohan 52 94 16
🥈 @Vaibhaav-Tiwari @Vaibhaav-Tiwari 39 60 9
🥉 @Rishet11 @Rishet11 30 52 62
4 @nikhilachale @nikhilachale 12 70 3
5 @somewherelostt @somewherelostt 12 50 1
6 @Prasad-D-Ware @Prasad-D-Ware 10 12 0
7 @Meraj-08 @Meraj-08 9 21 3
8 @illegalcall @illegalcall 9 19 3
9 @harshitsinghbhandari @harshitsinghbhandari 5 10 0
10 @neversettle17-101 @neversettle17-101 5 7 2

Ranked by distinct external PRs reviewed, then review rounds, then PR comments. Self-activity and bot activity are excluded.

Show 8 more reviewers
Rank Reviewer PRs reviewed Review rounds PR comments
11 @Pritom14 @Pritom14 5 6 4
12 @ApexYash11 @ApexYash11 4 13 2
13 @Annieeeee11 @Annieeeee11 3 5 2
14 @mohakchakraborty2004 @mohakchakraborty2004 3 4 0
15 @codebanditssss @codebanditssss 3 3 1
16 @Vansh-Singhal @Vansh-Singhal 1 3 1
17 @wesleymatosdev @wesleymatosdev 1 2 1
18 @AgentWrapper @AgentWrapper 1 1 0

@MohamedKamran
MohamedKamran added this pull request to stack #7842 November 5, 2026 15:21
@MohamedKamran
MohamedKamran force-pushed the mobile-native-overhaul/03 branch from 49c0d7a to 58c47b7 Compare November 5, 2026 15:26
@OrcInc OrcInc added comp/mobile Expo mobile product surface. enhancement New feature or request labels Nov 5, 2026

@Prasad-D-Ware Prasad-D-Ware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Shared files only gain additions, as the description says: tokens, theme and composer styles add without changing anything, Button and EmptyState gain props, and Feather icon names still draw with Feather. These screens reach #7839 unchanged. The round-4 onboarding fix is in: Sign in syncs the account's machines, then finishes onboarding or offers pairing. CI is green.

Nits (both gone after #7839):

  • The old manual-connect sheet (sheets/connect / connectSheetRoute) is still registered with no callers.
  • A comment in sessionRoute.ts points at app/(tabs)/(workers)/index.tsx, which only exists from #7839.

Pairing from onboarding and from the old board's Scan button hasn't been run on a simulator yet. Please cover it in the device run.

@OrcInc OrcInc added this to the Desktop & UI milestone Nov 5, 2026
@MohamedKamran
MohamedKamran force-pushed the mobile-native-overhaul/03 branch from 58c47b7 to 59904d1 Compare November 6, 2026 10:03
MohamedKamran and others added 5 commits November 6, 2026 15:37
…tive screens use

Adds without changing existing values: stateOpacity, rowIconWidth and onCamera
tokens, the theme's onDestructive ink, platform press feedback, the Compose
grouped list, the composer's field sizing, and connectRoute. Button gains a
tonal secondary variant and system-symbol icons, EmptyState a busy spinner, a
visual and an icon colour, and NumberedStep a step count for screen readers.

Machines now draw as system symbols everywhere; MachineGlyph stays for the
Workers filter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…vely

Settings becomes a SwiftUI Form on iOS and an M3 list on Android, led by the
account as the desktop shows it, with machines listed in Settings itself and
each opening a machine page. Pairing is a page with a native header, manual
connect a page pushed over it, and onboarding a picture, one line and Connect.
Removes the Environments page the machine list replaces. Android plays the
system's own haptic feedback.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Terminal messages show as platform notices, the input bar matches the chat
composer with a native Chat/Terminal switch, the key row uses native-sized
symbol keys, and a scroll-to-top control floats over the output. Voice input
reports its level for the composer's meter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Folders open as pages and search lives in the header, with native segmented
controls; the viewer's controls fold into header items, images zoom on both
platforms, diffs open in the viewer, and the queued review opens as a sheet.
The artifact page uses the new review button.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reload, progress and history in the app preview, a native header menu to
choose the view, and RNGH tap, pan and pinch for the live browser.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MohamedKamran
MohamedKamran force-pushed the mobile-native-overhaul/03 branch from 59904d1 to aaed8dc Compare November 6, 2026 10:08
@MohamedKamran

Copy link
Copy Markdown
Collaborator Author

@Prasad-D-Ware thanks! Leaving both nits since #7839 removes the old connect sheet and adds the Workers route the sessionRoute.ts comment points at. Ran pairing on the simulator from onboarding and from the old board's Scan button, and both work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/mobile Expo mobile product surface. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants