Repository navigation
feat(mobile): rebuild Settings, Machines, terminal, Files and preview natively (native overhaul 3/4) - #7838
Conversation
This branch (#7419) was too large to review: 354 commits and 858 files. Its history couldn't be split by cherry-picking. Most commits fix earlier ones, and a few commits touch hundreds of files across every area. So the split was rebuilt from this branch's final code, merged with current main, as a stack of four PRs. Each one typechecks and passes the full mobile suite on top of the one below it: 1. #7836 mobile-native-overhaul/01: native toolchain, config plugins and assets (dependencies, patches, plugins, icons, fonts). 2. #7837 mobile-native-overhaul/02: 180 new building-block files that nothing on main imports yet. 3. #7838 mobile-native-overhaul/03: Settings, Machines, pairing, onboarding, terminal, Files and preview, rebuilt natively. 4. #7839 mobile-native-overhaul/04: native tabs, the shared restyle, Workers, Projects and Pull Requests, New task, chat, and removal of the old code. Merge them in order, using merge commits for 1-3 and a squash for 4. After each merge, retarget the next PR to main. The tip of #7839 is identical to this branch merged with main, so main ends up with exactly this work. #7838 carries a little bridging code that never existed here. It adds new tokens, theme fields and ui props, keeps MachineGlyph and sharedMachineSymbols, registers its new routes in the root layout, and updates a few tests for the in-between state. It lets those screens run beside the old board and chat until #7839 replaces it with this branch's versions. This commit changes no files. This branch and #7419 stay as the reference; close #7419 once #7839 merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🏆 Review leaderboardOct 29, 2026–Nov 5, 2026 · UTC
Ranked by distinct external PRs reviewed, then review rounds, then PR comments. Self-activity and bot activity are excluded. Show 8 more reviewers
|
49c0d7a to
58c47b7
Compare
Prasad-D-Ware
left a comment
There was a problem hiding this comment.
Approving. Shared files only gain additions, as the description says: tokens, theme and composer styles add without changing anything, Button and EmptyState gain props, and Feather icon names still draw with Feather. These screens reach #7839 unchanged. The round-4 onboarding fix is in: Sign in syncs the account's machines, then finishes onboarding or offers pairing. CI is green.
Nits (both gone after #7839):
- The old manual-connect sheet (
sheets/connect/connectSheetRoute) is still registered with no callers. - A comment in
sessionRoute.tspoints atapp/(tabs)/(workers)/index.tsx, which only exists from #7839.
Pairing from onboarding and from the old board's Scan button hasn't been run on a simulator yet. Please cover it in the device run.
58c47b7 to
59904d1
Compare
…tive screens use Adds without changing existing values: stateOpacity, rowIconWidth and onCamera tokens, the theme's onDestructive ink, platform press feedback, the Compose grouped list, the composer's field sizing, and connectRoute. Button gains a tonal secondary variant and system-symbol icons, EmptyState a busy spinner, a visual and an icon colour, and NumberedStep a step count for screen readers. Machines now draw as system symbols everywhere; MachineGlyph stays for the Workers filter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…vely Settings becomes a SwiftUI Form on iOS and an M3 list on Android, led by the account as the desktop shows it, with machines listed in Settings itself and each opening a machine page. Pairing is a page with a native header, manual connect a page pushed over it, and onboarding a picture, one line and Connect. Removes the Environments page the machine list replaces. Android plays the system's own haptic feedback. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Terminal messages show as platform notices, the input bar matches the chat composer with a native Chat/Terminal switch, the key row uses native-sized symbol keys, and a scroll-to-top control floats over the output. Voice input reports its level for the composer's meter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Folders open as pages and search lives in the header, with native segmented controls; the viewer's controls fold into header items, images zoom on both platforms, diffs open in the viewer, and the queued review opens as a sheet. The artifact page uses the new review button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reload, progress and history in the app preview, a native header menu to choose the view, and RNGH tap, pan and pinch for the live browser. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
59904d1 to
aaed8dc
Compare
|
@Prasad-D-Ware thanks! Leaving both nits since #7839 removes the old connect sheet and adds the Workers route the |
Code changes: +5682 -3093
Tests: +4255 -531
Others: +0 -0
Important
Stacked PR 3 of 4: the mobile native overhaul, split from #7419. Merge in order:
Base:
mobile-native-overhaul/02(#7837). The diff shows only this PR's changes.Do not merge until #7837 has merged. Once it has, this PR retargets to
main(or rungh pr edit 7838 --base main); then wait for CI and merge.How to merge: use Create a merge commit (each commit here builds on its own). Then delete
mobile-native-overhaul/03so #7839 retargets.Merge #7839 soon after this one, and don't cut a mobile release between them. Until #7839 lands, these screens sit beside the old board and chat.
What
Settings, Machines, pairing and onboarding, the terminal, Files and preview, rebuilt on native controls. Five commits:
stateOpacity,rowIconWidthandonCameratokens and the theme'sonDestructive;connectRoute;secondaryButton with system-symbol icons, and a busyEmptyState.Why
These screens depend only on the shared pieces in commit 1, not on the new navigation or on each other. So they can land before #7839, which carries the navigation switch and the board and chat.
Before / After
Screenshots of each screen on iOS and Android will be added from a simulator run.
How
This PR adds a little code that never existed on #7419. It lets these screens run while the board and chat are still the old ones, and #7839 replaces all of it with the final versions:
tokens,theme,themeDerive,ui,chat/composerStylesandsheetResult. Today's screens render exactly as before.MachineGlyphandsharedMachineSymbolsstay, for the current Workers filter.AppSymbol, and font and haptics mocks.Reviewer focus:
ui.tsx. Existing Feather icon names still draw with Feather.Testing
npm run typecheckpasses, andnpm testpasses 333 files and 3,185 tests.Checklist
main(or continuing an existing PR branch)go, frontend, etc.)🤖 Generated with Claude Code