Skip to content

feat(mobile): add the native UI building blocks (native overhaul 2/4) - #7837

Merged
Prasad-D-Ware merged 9 commits into
mobile-native-overhaul/01from
mobile-native-overhaul/02
Nov 6, 2026
Merged

Prasad-D-Ware merged 9 commits into
mobile-native-overhaul/01from
mobile-native-overhaul/02

Conversation

@MohamedKamran

@MohamedKamran MohamedKamran commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Code changes: +6375 -0
Tests: +2755 -0
Others: +0 -0

Important

Stacked PR 2 of 4: the mobile native overhaul, split from #7419. Merge in order:

Order PR Contents
1 #7836 Native toolchain: dependencies, patches, config plugins, assets
2 #7837 ← this PR New building blocks (nothing imports them yet)
3 #7838 Settings, Machines, terminal, Files and preview
4 #7839 Native tabs, board, New task, chat, old-code removal

Base: mobile-native-overhaul/01 (#7836). The diff shows only this PR's changes.

Do not merge until #7836 has merged. Once it has, this PR retargets to main (or run gh pr edit 7837 --base main); then wait for CI and merge.

How to merge: use Create a merge commit (each commit here builds on its own). Then delete mobile-native-overhaul/02 so #7838 retargets.

What

The new building blocks the native screens are made of: 180 new files, nothing changed or removed. Nothing on main imports them yet; #7838 and #7839 adopt them.

Nine commits, one per area:

  1. System symbols, platform tokens and SwiftUI type.
    • AppSymbol draws SF Symbols on iOS and Material Symbols on Android.
    • Toolbar and chrome icon lookups, 48dp Android touch targets, and Dynamic Type text styles for SwiftUI.
  2. Shared native chrome.
    • A Toast that is a Snackbar on Android and a HUD on iOS, a shared Spinner and native form fields.
    • The M3 add FAB, tab pages and their insets, stack screen options and header back handling.
  3. Machine and settings pieces: the naming form and symbol menu, connection and editor hooks, manual connect.
  4. Effort and model: the effort slider and gauge, per-model effort levels and the spawn approval model.
  5. Board pieces: the worker filter menu, PR card menu icons and the native review action button.
  6. Chat pieces: jump to latest, keyboard follower, composer search field, usage sheet, elicitation input, PR chip and the dictation field.
  7. Terminal pieces: the terminal menu model, the Chat/Terminal switch confirm and route toggle, scroll-to-top and platform notices.
  8. Files pieces: segmented choice, review button, queued comments, file icons and code metrics.
  9. Preview pieces: native browser controls, the loading bar, the open-URL prompt, load progress and frame zoom.

Why

Landing the new components on their own keeps #7838 and #7839 to the screen changes, and lets each component be reviewed with its tests.

Before / After

No user-visible change: every file is new and nothing on main imports it yet.

How

  • Selection: only files that typecheck against today's code are here. Anything that needs a changed existing file waits for the PR that changes it.
  • Platform files: no .ios/.android file here shadows an existing file, so Metro resolves every existing import as before.
  • Tests: 18 tests that pin behaviour of existing files, or scan the whole tree, move to the later PRs with the code they check.

Testing

  • Every one of the nine commits typechecks and passes the full suite on its own (2,820 → 2,973 tests).
  • At the tip: npm run typecheck passes, and npm test passes 313 files and 2,973 tests.

Checklist

  • Branched from main (or continuing an existing PR branch)
  • One focused change; links the related issue when applicable
  • Follows AGENTS.md conventions and PR hygiene
  • Before / After filled in; UI changes include screenshots or a recording
  • Tests added/updated for user-visible behavior where it makes sense
  • Relevant CI checks pass for the area touched (go, frontend, etc.)

🤖 Generated with Claude Code

@MohamedKamran
MohamedKamran marked this pull request as ready for review November 5, 2026 15:06
MohamedKamran added a commit that referenced this pull request Nov 5, 2026
This branch (#7419) was too large to review: 354 commits and 858 files. Its
history couldn't be split by cherry-picking. Most commits fix earlier ones,
and a few commits touch hundreds of files across every area.

So the split was rebuilt from this branch's final code, merged with current
main, as a stack of four PRs. Each one typechecks and passes the full mobile
suite on top of the one below it:

1. #7836 mobile-native-overhaul/01: native toolchain, config plugins and
   assets (dependencies, patches, plugins, icons, fonts).
2. #7837 mobile-native-overhaul/02: 180 new building-block files that nothing
   on main imports yet.
3. #7838 mobile-native-overhaul/03: Settings, Machines, pairing, onboarding,
   terminal, Files and preview, rebuilt natively.
4. #7839 mobile-native-overhaul/04: native tabs, the shared restyle, Workers,
   Projects and Pull Requests, New task, chat, and removal of the old code.

Merge them in order, using merge commits for 1-3 and a squash for 4. After
each merge, retarget the next PR to main. The tip of #7839 is identical to
this branch merged with main, so main ends up with exactly this work.

#7838 carries a little bridging code that never existed here. It adds new
tokens, theme fields and ui props, keeps MachineGlyph and
sharedMachineSymbols, registers its new routes in the root layout, and
updates a few tests for the in-between state. It lets those screens run
beside the old board and chat until #7839 replaces it with this branch's
versions.

This commit changes no files. This branch and #7419 stay as the reference;
close #7419 once #7839 merges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🏆 Review leaderboard

Oct 29, 2026–Nov 5, 2026 · UTC

Rank Reviewer PRs reviewed Review rounds PR comments
🥇 @ronishrohan @ronishrohan 52 94 16
🥈 @Vaibhaav-Tiwari @Vaibhaav-Tiwari 39 60 9
🥉 @Rishet11 @Rishet11 30 52 62
4 @nikhilachale @nikhilachale 12 70 3
5 @somewherelostt @somewherelostt 12 50 1
6 @Prasad-D-Ware @Prasad-D-Ware 10 12 0
7 @Meraj-08 @Meraj-08 9 21 4
8 @illegalcall @illegalcall 9 19 3
9 @harshitsinghbhandari @harshitsinghbhandari 5 10 0
10 @neversettle17-101 @neversettle17-101 5 7 2

Ranked by distinct external PRs reviewed, then review rounds, then PR comments. Self-activity and bot activity are excluded.

Show 8 more reviewers
Rank Reviewer PRs reviewed Review rounds PR comments
11 @Pritom14 @Pritom14 5 6 4
12 @ApexYash11 @ApexYash11 4 13 2
13 @Annieeeee11 @Annieeeee11 3 5 2
14 @mohakchakraborty2004 @mohakchakraborty2004 3 4 0
15 @codebanditssss @codebanditssss 3 3 1
16 @Vansh-Singhal @Vansh-Singhal 1 3 1
17 @wesleymatosdev @wesleymatosdev 1 2 1
18 @AgentWrapper @AgentWrapper 1 1 0

@Prasad-D-Ware Prasad-D-Ware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. 180 new files with nothing changed or deleted. No .ios/.android file overrides an existing one, there are no new routes, and every file reaches #7839 unchanged, so this is the final code. CI is green.

Question, not blocking: spawnApproval.ts hardcodes which approval modes each agent offers. The desktop hides Bypass for Antigravity (agy) in its per-message picker and filters New chat against a list from the daemon, while this offers Bypass for agy at spawn. The daemon does accept Bypass for agy, so it's a parity question. Could this read the daemon's list the way the desktop does?

@OrcInc OrcInc added this to the Desktop & UI milestone Nov 5, 2026
@MohamedKamran
MohamedKamran force-pushed the mobile-native-overhaul/02 branch from 5fb3b37 to 27bc817 Compare November 6, 2026 10:03
MohamedKamran and others added 9 commits November 6, 2026 15:37
AppSymbol draws SF Symbols on iOS and Material Symbols on Android, with the
codepoint tables, toolbar and chrome icon lookups behind it. Platform tokens
size touch targets at 48dp on Android, and swiftUIFont sizes SwiftUI text
from Dynamic Type styles.

Nothing imports these yet; the native UI switch adopts them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd header pieces

A Toast that is a Snackbar on Android and a HUD on iOS, a shared Spinner,
native form fields, the M3 add FAB, tab pages and their insets, stack screen
options, header back handling and the board tab model.

Nothing imports these yet; the native UI switch adopts them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Machine naming form and symbol menu, connection and editor hooks, manual
connect, environment actions and notices, and the settings form types.

Nothing imports these yet; the native UI switch adopts them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The effort slider and gauge with their hook, the per-model effort levels, and
the spawn approval model shared by chat and New task.

Nothing imports these yet; the native UI switch adopts them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The worker filter menu, PR card menu icons and filter control types, and the
native review action button.

Nothing imports these yet; the native UI switch adopts them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jump to latest, keyboard follower, composer search field, usage sheet,
elicitation input, PR chip, chat menu icons, timeline scroll and the
dictation field.

Nothing imports these yet; the native UI switch adopts them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The terminal menu model, Chat/Terminal interface switch confirm and route
toggle, scroll-to-top button, platform notices and the session preview hook.

Nothing imports these yet; the native UI switch adopts them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Segmented choice, review button, queued comments, file row menu types, file
icons, code metrics and the file actions hook.

Nothing imports these yet; the native UI switch adopts them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…preview

Native browser controls, the loading bar, the open-URL prompt, the preview
mode menu, load progress and frame zoom.

Nothing imports these yet; the native UI switch adopts them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MohamedKamran
MohamedKamran force-pushed the mobile-native-overhaul/02 branch from 27bc817 to af86563 Compare November 6, 2026 10:08
@MohamedKamran

Copy link
Copy Markdown
Collaborator Author

@Prasad-D-Ware on the spawnApproval.ts question: good catch. It is parity rather than a bug, since the daemon accepts Bypass for agy, so I will keep it out of this stack. I will file an issue for it and follow up with a PR that has New task read the daemon's approval modes (as the desktop does with useChatPermissionModesQuery) instead of the hardcoded list.

@Prasad-D-Ware
Prasad-D-Ware merged commit b966594 into main Nov 6, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/mobile Expo mobile product surface. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants