Repository navigation
chore(mobile): native toolchain, config plugins and assets (native overhaul 1/4) - #7836
Conversation
🏆 Review leaderboardOct 29, 2026–Nov 5, 2026 · UTC
Ranked by distinct external PRs reviewed, then review rounds, then PR comments. Self-activity and bot activity are excluded. Show 8 more reviewers
|
This branch (#7419) was too large to review: 354 commits and 858 files. Its history couldn't be split by cherry-picking. Most commits fix earlier ones, and a few commits touch hundreds of files across every area. So the split was rebuilt from this branch's final code, merged with current main, as a stack of four PRs. Each one typechecks and passes the full mobile suite on top of the one below it: 1. #7836 mobile-native-overhaul/01: native toolchain, config plugins and assets (dependencies, patches, plugins, icons, fonts). 2. #7837 mobile-native-overhaul/02: 180 new building-block files that nothing on main imports yet. 3. #7838 mobile-native-overhaul/03: Settings, Machines, pairing, onboarding, terminal, Files and preview, rebuilt natively. 4. #7839 mobile-native-overhaul/04: native tabs, the shared restyle, Workers, Projects and Pull Requests, New task, chat, and removal of the old code. Merge them in order, using merge commits for 1-3 and a squash for 4. After each merge, retarget the next PR to main. The tip of #7839 is identical to this branch merged with main, so main ends up with exactly this work. #7838 carries a little bridging code that never existed here. It adds new tokens, theme fields and ui props, keeps MachineGlyph and sharedMachineSymbols, registers its new routes in the root layout, and updates a few tests for the in-between state. It lets those screens run beside the old board and chat until #7839 replaces it with this branch's versions. This commit changes no files. This branch and #7419 stay as the reference; close #7419 once #7839 merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
55f3a97 to
b229ade
Compare
Prasad-D-Ware
left a comment
There was a problem hiding this comment.
Reviewed as part of the four-PR split of #7419. Once all four merge, the tree is byte-for-byte #7419 merged into current main (checked with git merge-tree). CI is green at this head.
One change before merge: please drop plugins/withIosSceneLifecycle.js and lib/iosSceneLifecycle.source.test.ts and use Expo's built-in scene support instead. The expo-build-properties version this PR moves to (57.0.22) has ios.enableSceneSupport: true. It writes the same UIApplicationSceneManifest and makes the same AppDelegate change. With expo 57.0.31 it's supported, and it's maintained upstream, so it won't break on the next SDK the way a regex rewrite of the AppDelegate template will.
[
"expo-build-properties",
{
"android": { "usesCleartextTraffic": true },
"ios": { "enableSceneSupport": true }
}
]Please re-check an iOS 27 launch after the swap.
Everything else looks good:
- The pins are consistent: react-native-screens resolves to exactly the 4.26.2 its patch targets, @expo/ui to 57.0.26 and expo to 57.0.31.
predictiveBackGestureEnabled: falsefixes a real bug on main, where Back left the app from a pushed page on Android 13–15. Please say so in the description; 2dab011's message explains it well.- I found no bug in the @expo/ui
DropdownMenupatch's placement logic, including right-to-left. It does replace Material's menu with our own copy, though, so it's a fork to maintain and worth raising upstream.
Nit: until #7839 lands, Android dialogs use #7839's colours rather than main's, and the test that keeps the two in step only arrives in #7839.
Still needed for the stack: Before/After screenshots, and a device run of the round-4 items (status bar, keyboard, light-mode board frost, Android menu gap).
…bols Moves every Expo SDK 57 package to its latest patch, adds expo-symbols and sf-symbols-typescript for system glyphs, and builds expo-ui from source on Android so the patch below applies. Vitest mocks expo-symbols once, since it cannot load under node. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- react-native-screens: answer UIKit's shouldSelectTab on iOS 18+, so a tab iOS 26 sets apart (the search item) honours preventNativeSelection. - @expo/ui (Android): let the app set a Material theme per colour scheme, give Text the font family of the slot it sits in, and open DropdownMenu against its anchor in the app's window rather than under the status bar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…them Material drawables, harness menu image sets, tab icons and DM Sans, with the scripts that regenerate the generated sets. Nothing references them yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- withIosSceneLifecycle adopts the scene life cycle, without which iOS 27 traps at launch. - withIosSoftScrollEdge keeps the soft scroll edge under the glass bar on iOS 27 only. - withAndroidDialogTheme gives Alert dialogs Material 3 shape and the app's palette. - withHarnessMenuIcons copies the harness menu image sets into the asset catalog. Turns off Android predictive back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
expo-build-properties 57.0.22 ships ios.enableSceneSupport, which writes the same UIApplicationSceneManifest and makes the same AppDelegate change as withIosSceneLifecycle (prebuild output is byte-identical). Expo maintains it across SDK patches, so drop our regex rewrite of the AppDelegate template and its source test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
58b337a to
e6998ef
Compare
Prasad-D-Ware
left a comment
There was a problem hiding this comment.
Thanks, the scene fix looks right. e6998ef05e drops withIosSceneLifecycle and its source test and sets ios.enableSceneSupport: true through expo-build-properties. The lock has Expo 57.0.31, which supports the flag, and nothing at the stack tip still references the old plugin. The rebase left every other commit's diff unchanged, CI is green, and the iOS 27.2 screenshots on #7839 show the app launching with Expo's scene support. Approving.
Code changes: +734 -0
Tests: +68 -0
Others: +2338 -336 (assets, patches, package files, lockfile; plus 90 binary icon and font files)
Important
Stacked PR 1 of 4: the mobile native overhaul, split from #7419. Merge in order:
Base:
main. This is the bottom of the stack and can be merged first.How to merge: use Create a merge commit (each commit here builds on its own). Then delete the
mobile-native-overhaul/01branch so #7837 retargets tomainautomatically.What
The native groundwork for the mobile overhaul: dependencies, native patches, Expo config plugins and the icon and font assets the later PRs draw with.
expo-symbolsandsf-symbols-typescriptare added for system glyphs. Android buildsexpo-uifrom source so its patch applies. Vitest mocksexpo-symbolsonce in a shared setup file.react-native-screens: answers UIKit'sshouldSelectTabon iOS 18+, so the tab iOS 26 sets apart honourspreventNativeSelection.@expo/ui(Android): lets the app set a Material theme per colour scheme, givesTextits slot's font family, and opensDropdownMenuagainst its anchor rather than under the status bar.expo-build-properties'ios.enableSceneSupportadopts it. Without it, iOS 27 traps at launch. This is Expo's own option, maintained across SDK patches, rather than a plugin of ours.withIosSoftScrollEdgekeeps the soft scroll edge under the glass bar, on iOS 27 only.withAndroidDialogThemegivesAlertdialogs Material 3 shape and the app's palette.withHarnessMenuIconscopies the harness menu image sets into the asset catalog.main: on Android 13–15, Back (gesture or key) from a pushed page, such as a project opened from Projects, left the app instead of going back.Why
#7419 is too large to review (858 files). This splits it into four PRs that each build and pass the full mobile suite on their own base. This one carries everything native, so it can be checked on devices by itself.
Before / After
Alertdialogs: AppCompat's grey slab, square corners, upper-case teal buttonsDropdownMenucan open under the status barScreenshots of the
Alertdialog and a menu on Android, and of iOS launch, will be added from a simulator run.How
iosSoftScrollEdge,harnessMenuIcons).expo prebuildwrites the sameAppDelegate.swiftandInfo.plistwithenableSceneSupportas with the hand-written plugin it replaces (checked byte for byte).Testing
npm run typecheck: passes.npm test: 268 files, 2,800 tests pass.expo prebuild --platform ios: succeeds with no warnings.npm ci(local runs used an install from this lockfile);Checklist
main(or continuing an existing PR branch)go, frontend, etc.)🤖 Generated with Claude Code