chore: bump @zk-email/sdk to 3.0.0-nightly.36 - #321
Merged
Merged
Conversation
Contains the fix for Blueprint.verifyProofOnChain discarding the standalone call's boolean result (zkemail/zk-email-sdk-js#104), which Jordan flagged: a tampered proof was reporting success through this exact method, the one this registry's UI calls.
render
Bot
temporarily deployed
to
chore/bump-sdk-nightly-36 - registry-staging PR #321
August 26, 2026 17:02
Destroyed
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
benceharomi
added a commit
that referenced
this pull request
Aug 26, 2026
…ation Real UI path (Verify On-Chain button -> blueprint.verifyProofOnChain), same real proof as verifyProofOnChain.ts but corrupted in-flight via route interception, not the persisted database record. Asserts the failure toast, not the success one. Expected to fail against current staging: blueprint.verifyProofOnChain discards the standalone call's result and always resolves true unless the SDK itself throws, so a tampered proof currently shows the success toast here (curator-reported bug, fixed in zkemail/zk-email-sdk-js#104, not yet on staging until #321 merges). This PR demonstrates that on real CI before the fix lands, then should pass once #321 merges and this branch is rebased.
benceharomi
added a commit
that referenced
this pull request
Aug 26, 2026
…ation (#322) Real UI path (Verify On-Chain button -> blueprint.verifyProofOnChain), same real proof as verifyProofOnChain.ts but corrupted in-flight via route interception, not the persisted database record. Asserts the failure toast, not the success one. Expected to fail against current staging: blueprint.verifyProofOnChain discards the standalone call's result and always resolves true unless the SDK itself throws, so a tampered proof currently shows the success toast here (curator-reported bug, fixed in zkemail/zk-email-sdk-js#104, not yet on staging until #321 merges). This PR demonstrates that on real CI before the fix lands, then should pass once #321 merges and this branch is rebased.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@zk-email/sdkversion from3.0.0-nightly.34to3.0.0-nightly.36.nightly.36contains the fix forBlueprint.verifyProofOnChaindiscarding the standalone call's boolean result (fix: propagate the real verification result from blueprint.verifyProofOnChain zk-email-sdk-js#104), reported by curator Jordan during the Kusama grant M3 review: a tampered proof was reporting success through this exact method, which this registry's UI (ProofRow.tsx,proofs/[proofId]/page.tsx) calls directly to drive the verify success/failure toast.Test plan
bun run buildpasses cleanly with the bumped version (only pre-existing, unrelated lint warnings).