test(kusama): add Playwright test for tampered proof on-chain verification - #322
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ation Real UI path (Verify On-Chain button -> blueprint.verifyProofOnChain), same real proof as verifyProofOnChain.ts but corrupted in-flight via route interception, not the persisted database record. Asserts the failure toast, not the success one. Expected to fail against current staging: blueprint.verifyProofOnChain discards the standalone call's result and always resolves true unless the SDK itself throws, so a tampered proof currently shows the success toast here (curator-reported bug, fixed in zkemail/zk-email-sdk-js#104, not yet on staging until #321 merges). This PR demonstrates that on real CI before the fix lands, then should pass once #321 merges and this branch is rebased.
benceharomi
force-pushed
the
test/verify-tampered-proof-on-chain
branch
from
August 26, 2026 18:29
1582f93 to
41d62cd
Compare
render
Bot
temporarily deployed
to
test/verify-tampered-proof-on-chain - registry-staging PR #322
August 26, 2026 18:29
Destroyed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyProofOnChain.tsbut corrupting the proof in-flight via route interception (the persisted proof in the database is never touched).Expected result on this PR (before #321 merges)
This is expected to fail right now:
stagingis still pinned to@zk-email/sdk@3.0.0-nightly.34, which has the bugblueprint.verifyProofOnChaindiscards the standalone call's boolean result and always resolvestrueunless the SDK itself throws. A tampered proof currently shows the success toast through this exact button.Plan
nightly.36, contains the fix) first.staging.Deliberately not merging this one until that sequence completes, so the red-then-green CI history stays as evidence.