Skip to content

Update python.yaml#51971

Open
Bernie-mirsee wants to merge 3 commits into
ros:masterfrom
Bernie-mirsee:master
Open

Update python.yaml#51971
Bernie-mirsee wants to merge 3 commits into
ros:masterfrom
Bernie-mirsee:master

Conversation

@Bernie-mirsee

Copy link
Copy Markdown

Please add the following dependency to the rosdep database.

Package name:

piper-tts

Package Upstream Source:

https://github.com/rhasspy/piper

Purpose of using this:

Piper is a general-purpose text-to-speech engine, which is useful for providing speech output in ROS.

Distro packaging links:

https://pypi.org/project/piper-tts/

@Bernie-mirsee Bernie-mirsee requested a review from a team as a code owner June 9, 2026 19:57
@github-actions github-actions Bot added the rosdep Issue/PR is for a rosdep key label Jun 9, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the Infrastructure General channel on our Zulip server.


For changes related to rosdep:

  • ❌ There are problems with the names of new rosdep keys:
    • Keys which contain only pip rules should end in '-pip'
  • ✅ Platforms for new rosdep rules are valid
  • ✅ Installers for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep
  • 📝 Disclaimer: Pip-only rules cannot be used by packages on the ROS buildfarm

For changes related to yamllint:

  • ❌ One or more linter violations were added to YAML files

Comment thread rosdep/python.yaml Outdated
packages: [pathos]
python-pathtools:
debian: [python-pathtools]
python-pathvalidate:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key should end in '-pip'

Comment thread rosdep/python.yaml Outdated
openembedded: ['${PYTHON_PN}-pip@meta-python']
opensuse: [python2-pip]
ubuntu: [python-pip]
python-piper-tts:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key should end in '-pip'

Comment thread rosdep/python.yaml Outdated
ubuntu:
pip:
packages: [pathvalidate]
debian:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line does not pass YAML linter checks: wrong ordering of key "debian" in mapping

Comment thread rosdep/python.yaml Outdated
ubuntu:
pip:
packages: [piper-tts]
debian:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line does not pass YAML linter checks: wrong ordering of key "debian" in mapping

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ Installers for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep
  • 📝 Disclaimer: Pip-only rules cannot be used by packages on the ROS buildfarm

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@github-actions github-actions Bot dismissed their stale review June 19, 2026 17:32

Previous automated review is stale

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ✅ Platforms for new rosdep rules are valid
  • ✅ Installers for new rosdep rules are valid
  • ✅ New keys appear suitable for rosdep
  • 📝 Disclaimer: Pip-only rules cannot be used by packages on the ROS buildfarm

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rosdep Issue/PR is for a rosdep key

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants