rosdep: drop legacy Python 2 keys - Stage 5 (100%)#51720
Conversation
There was a problem hiding this comment.
Thanks for sending a pull request to ROS distro!
This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.
ROS Distro Considerations
- ROS Distributions are created using REP-134 Standards Track as a guide.
- Your package name should comply to REP-144 ROS Package Naming
- Your package must build for all platforms and architectures on the ROS buildfarm. See REP-2000 ROS Releases and Supported Platforms for all supported platforms for your ROS Distro.
- Your package must contain an OSI approved license. Your
package.xmlfile must also include that license in a machine readable format. See REP-149 Package Manifest Format Three Specification for additional details. - A publicly available, open source, repository for your ROS package.
- While not required, we recommend that you create an account for ROS Discourse and subscribe to the appropriate release topic.
- If you would like, you may join our Zulip Server and ask questions in the
Infrastructure Generalchannel.
Package Considerations
Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.
- REP-2004 Package Quality Declaration-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher.
- Documentation -- it is recommended that ROS packages include an extensive README.md file, and API level documentation using the Sphinx documentation system.
- Maintainer Responsibilities -- the ROS 2 documentation includes a guide to ROS package maintainer responsibilities that summarizes your responsibilities as an open source maintainer. While we do not enforce these requirements on package maintainers they should be considered best practices.
- We recommend that your package should strive to conform to the ROS 2 Developer Guide and the ROS 2 Style Guide.
Need Help?
Please post your questions to Robotics Stack Exchange or refer to the Infrastructure General channel on our Zulip server.
For changes related to rosdep:
- ❌ There are problems with the names of new rosdep keys:
- Keys which contain only pip rules should end in '-pip'
- ✅ Platforms for new rosdep rules are valid
- ❌ There are problems with explicitly provided installers:
- One or more explicitly provided installer is not supported by rosdep
- ❌ There are problems with rosdep key suitability:
- Rules exclusively for pip may not be added when there are system packages available
- 📝 Disclaimer: Pip-only rules cannot be used by packages on the ROS buildfarm
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
| @@ -5417,7 +1189,23 @@ python3-cffi: | |||
| nixos: [python3Packages.cffi] | |||
| rhel: ['python%{python3_pkgversion}-cffi'] | |||
| ubuntu: [python3-cffi] | |||
| python3-chainer-pip: *migrate_eol_2025_04_30_python3_chainer_pip | |||
| python3-chainer-pip: | |||
There was a problem hiding this comment.
This key should not end in '-pip'
| @@ -10451,7 +6360,18 @@ python3-sphinx-rtd-theme: | |||
| nixos: [python3Packages.sphinx_rtd_theme] | |||
| rhel: ['python%{python3_pkgversion}-sphinx_rtd_theme'] | |||
| ubuntu: [python3-sphinx-rtd-theme] | |||
| python3-spidev-pip: *migrate_eol_2025_04_30_python3_spidev_pip | |||
| python3-spidev-pip: | |||
There was a problem hiding this comment.
This key should not end in '-pip'
| pip: | ||
| packages: [j1939] |
There was a problem hiding this comment.
Installer 'pip' is not supported for 'gentoo'
| @@ -8899,7 +4784,13 @@ python3-pymodbus: | |||
| fedora: [python3-pymodbus] | |||
| ubuntu: | |||
| '*': [python3-pymodbus] | |||
| python3-pymodbus-pip: *migrate_eol_2027_04_30_python3_pymodbus_pip | |||
| python3-pymodbus-pip: | |||
There was a problem hiding this comment.
There is already a non-pip key for python3-pymodbus
e934f3d to
d0cf44b
Compare
d0cf44b to
946f212
Compare
591a1db to
b00a409
Compare
946f212 to
c363078
Compare
b00a409 to
cd3b195
Compare
c363078 to
3abfadf
Compare
cd3b195 to
5f71d38
Compare
3abfadf to
00e4079
Compare
5f71d38 to
d935652
Compare
Drop the final batch (99 keys) of legacy Python 2 keys from the database. Inlined anchors for active Python 3 keys. Assisted-by: Gemini CLI:2.0-Pro [list_dir, view_file, run_command]
00e4079 to
ec194a7
Compare
d935652 to
169cadc
Compare
|
This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label. |
Part of Python 2 drop. Links to #51715