Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ The released versions correspond to PyPI releases.
(see [#1331](https://github.com/pytest-dev/pyfakefs/issues/1331))
* fixed cross-device hard links incorrectly succeeding
(see [#1337](https://github.com/pytest-dev/pyfakefs/issues/1337))
* fixed `os.rename` failing for the root user in a directory owned by
another user
(see [#1341](https://github.com/pytest-dev/pyfakefs/issues/1341))

## [Version 6.2.0](https://pypi.python.org/pypi/pyfakefs/6.2.0) (2026-04-12)

Expand Down
4 changes: 3 additions & 1 deletion pyfakefs/fake_filesystem.py
Original file line number Diff line number Diff line change
Expand Up @@ -1936,7 +1936,9 @@ def lresolve(self, path: AnyPath) -> FakeFile:
if not self.is_windows_fs and isinstance(parent_obj, FakeFile):
self.raise_os_error(errno.ENOTDIR, path_str)
self.raise_os_error(errno.ENOENT, path_str)
if not parent_obj.has_permission(helpers.PERM_READ):
if not helpers.is_root() and not parent_obj.has_permission(
helpers.PERM_READ
):
self.raise_os_error(errno.EACCES, parent_directory)
return (
parent_obj.get_entry(to_string(child_name))
Expand Down
16 changes: 16 additions & 0 deletions pyfakefs/tests/fake_os_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -5672,6 +5672,22 @@ def test_getgid(self):
reset_ids()
self.assertEqual(gid, self.os.getgid())

def test_rename_in_dir_of_other_user_as_root(self):
# regression test for #1341
self.skip_real_fs() # won't change user in real fs
self.check_posix_only()
self.addCleanup(reset_ids)
dir_path = self.make_path("other_user_dir")
file_path = self.os.path.join(dir_path, "some_file")
self.create_file(file_path)
self.os.chmod(dir_path, 0o700)
self.os.chown(dir_path, get_uid() + 1, get_gid() + 1)
new_path = self.os.path.join(dir_path, "new_file")
set_uid(0)
# root ignores the directory permissions
self.os.rename(file_path, new_path)
self.assertTrue(self.os.path.exists(new_path))

def test_listdir_unreadable_dir(self):
if not is_root():
self.assert_raises_os_error(errno.EACCES, self.os.listdir, self.dir_path)
Expand Down
Loading