Fix os.rename permission check for the root user - #1342
Merged
Merged
Conversation
- lresolve() was the only permission check without an is_root() test, so root could not rename an entry in a directory of another user - regression from pytest-dev#961, where the plain mode check was replaced by has_permission(), which also considers the owner - fixes pytest-dev#1341 Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov
force-pushed
the
wip-1341-root-rename
branch
from
September 22, 2026 09:16
25cbd0b to
6a3bbed
Compare
mrbean-bremen
approved these changes
Sep 22, 2026
mrbean-bremen
left a comment
mrbean-bremen
left a comment
Member
There was a problem hiding this comment.
Thanks, looks good!
The failing tests are another problem, some flaky tests with the new macOS version...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PermissionErrorwhen the parent directory belongs to another user #1341Describe the changes
The related issue or a description of the bug or feature that this PR addresses.
Tasks