desktop: stop cutting off the last row; default font 15 (0.2.5)

README.md

@@ -63,7 +63,8 @@ The layout (tabs, splits, each remote pane's host and session) is saved to
 `~/.config/hqterm/desktop-layout.json`, and the next launch reattaches every
 remote pane to its hqsh session; local panes come back as fresh shells.
 Settings: `~/.config/hqterm/desktop.json`, e.g.
-`{"fontFamily": "JetBrains Mono", "fontSize": 14, "theme": {"background": "#000"}, "restore": true}`.
+`{"fontFamily": "JetBrains Mono", "fontSize": 16, "theme": {"background": "#000"}, "restore": true}`
+(the default font size is 15).
 
 Develop: `cd desktop && npm install && npm start` (needs bun and a C++
 toolchain for node-pty); `npm run dist` builds the AppImage.

desktop/main.js

@@ -55,7 +55,7 @@ function loadConfig() {
   const c = readJson(configFile()) || {};
   return {
     fontFamily: typeof c.fontFamily === "string" && c.fontFamily.trim() ? c.fontFamily : "monospace",
-    fontSize: Number.isFinite(c.fontSize) && c.fontSize >= 6 && c.fontSize <= 72 ? c.fontSize : 14,
+    fontSize: Number.isFinite(c.fontSize) && c.fontSize >= 6 && c.fontSize <= 72 ? c.fontSize : 15,
     theme: c.theme && typeof c.theme === "object" ? c.theme : undefined,
     restore: c.restore !== false,
     gpu: c.gpu !== false,
@@ -338,6 +338,25 @@ if (!app.requestSingleInstanceLock()) {
             console.log(`hqterm-desktop smoke: screenshot failed: ${err && err.message}`);
           }
         }
+        // Every pane's rows must fit inside the pane: a fit that ignores the
+        // pane's padding cuts the last row off at the bottom.
+        let clipped = [];
+        try {
+          clipped = win
+            ? await win.webContents.executeJavaScript(`[...document.querySelectorAll(".pane")].flatMap((p) => {
+                const s = p.querySelector(".xterm-screen");
+                if (!s) return [];
+                const a = p.getBoundingClientRect(), b = s.getBoundingClientRect();
+                return b.bottom > a.bottom + 0.5 || b.right > a.right + 0.5
+                  ? [\`screen \${Math.round(b.width)}x\${Math.round(b.height)} in pane \${Math.round(a.width)}x\${Math.round(a.height)}\`]
+                  : [];
+              })`)
+            : [];
+        } catch {}
+        if (clipped.length) {
+          console.log(`hqterm-desktop smoke: clipped: ${clipped.join("; ")}`);
+          return app.exit(4);
+        }
         console.log(`hqterm-desktop smoke: ok (ptys=${ptys.size})`);
         app.exit(ptys.size > 0 ? 0 : 3);
       }, wait);

desktop/package.json

@@ -1,7 +1,7 @@
 {
   "name": "hqterm-desktop",
   "productName": "hqterm",
-  "version": "0.2.4",
+  "version": "0.2.5",
   "description": "hqterm desktop: a terminal window that shows hqtui/qc images and HD emoji (xterm.js + node-pty).",
   "license": "MIT",
   "author": "Profullstack, Inc. <hello@profullstack.com>",

desktop/src/app.js

@@ -617,9 +617,24 @@
     true,
   );
 
-  window.addEventListener("resize", () => {
+  const fitAll = () => {
     for (const rt of runtimes.values()) fitSoon(rt);
-  });
+  };
+  window.addEventListener("resize", fitAll);
+  // The cell size changes without the pane changing size when a font finishes
+  // loading or the window moves to a screen with another scale factor; refit
+  // then too, or the last row is cut off until the next window resize.
+  document.fonts.addEventListener("loadingdone", fitAll);
+  (function watchScale() {
+    matchMedia(`(resolution: ${window.devicePixelRatio}dppx)`).addEventListener(
+      "change",
+      () => {
+        fitAll();
+        watchScale();
+      },
+      { once: true },
+    );
+  })();
 
   // ---------- start ----------
 

desktop/src/style.css

@@ -223,8 +223,8 @@ button.icon:hover img {
   flex: 1;
   min-width: 0;
   min-height: 0;
-  padding: 4px 0 0 6px;
   position: relative;
+  overflow: hidden;
   outline: 1px solid transparent;
   outline-offset: -1px;
 }
@@ -233,8 +233,13 @@ button.icon:hover img {
   outline-color: #5ea1ff66;
 }
 
+/* The inset lives on .xterm, not .pane: FitAddon sizes rows from the parent's
+   computed height, which under border-box includes the parent's own padding,
+   so padding on .pane made it fit one row too many and clip the bottom. It
+   subtracts the terminal element's padding correctly. */
 .pane .xterm {
   height: 100%;
+  padding: 4px 0 0 6px;
 }
 
 body.dragging-row,

package.json

@@ -1,6 +1,6 @@
 {
   "name": "hqterm",
-  "version": "0.2.4",
+  "version": "0.2.5",
   "description": "Terminal session manager: persistent hqsh sessions with images and HD emoji, built on hqtui.",
   "license": "MIT",
   "private": true,