Repository navigation
desktop: stop cutting off the last row; default font 15 (0.2.5) - #6
Merged
Merged
Conversation
The pane's padding sat on .pane, and FitAddon sizes rows from the parent's computed height, which under border-box includes that padding. Whenever the pane height left under 4px spare after whole rows, it fitted one row too many and the bottom was clipped until a resize happened to land differently. The inset now lives on .xterm, whose padding FitAddon subtracts. Also refit when a font finishes loading or the display scale changes, and the CI smoke test fails if any pane's screen extends past its pane. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anthony: "the desktop app cuts/crops the bottom few pixels of the shell terminal unless i resize the window … very unprofessional", and "make default font size one size larger".
Cause.
.panehadpadding: 4px 0 0 6pxunderbox-sizing: border-box. FitAddon computes rows from the parent's computedheight, which under border-box includes the padding, and subtracts only the terminal element's own padding. Whenever the pane height left less than 4px to spare after whole rows, the fit added one row too many and the last row hung off the bottom. A resize "fixed" it only when the new height happened to land differently.Fix
.pane .xterm; FitAddon subtracts that..panegetsoverflow: hiddenas a backstop.document.fontsloadingdone) and when the display scale changes (moving monitors, fractional scaling). Both change the cell size while the pane stays the same size.clipped: …if any pane's.xterm-screenextends past its pane.node --checkpasses on main.js and app.js; layout tests: 6 pass.🤖 Generated with Claude Code