Repository navigation
fix: clarify cloudflare provider failures #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Phonton CLI v0.4.6 | ||
|
|
||
| Patch release for Cloudflare provider diagnostics. | ||
|
|
||
| ## Fixed | ||
|
|
||
| - Settings connection tests now surface the real Cloudflare setup requirement when the Account ID or Workers AI base URL is missing. | ||
| - Failed goals now show their failure reason in the Active panel, so provider setup issues stay visible after the run stops. | ||
|
|
||
| ## Verification | ||
|
|
||
| - `cargo fmt --all -- --check` | ||
| - `cargo clippy --locked --workspace --all-targets -- -D warnings` | ||
| - `cargo test --locked --workspace` | ||
| - `cargo build --release --locked -p phonton-cli` |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test assumes
test_provider(..., None, None)always fails before any network call, butmake_api_provider_configresolves Cloudflare base URL fromCLOUDFLARE_ACCOUNT_IDwhenaccount_idisNone, so in environments where that variable is set the provider config is valid and the test reaches a real API call path instead of returning the expected setup error. That makes the assertion flaky and environment-dependent; clear or overrideCLOUDFLARE_ACCOUNT_IDin this test to keep it deterministic.Useful? React with 👍 / 👎.