Repository navigation
fix: clarify cloudflare provider failures - #8
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa6052e566
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| None, | ||
| None, | ||
| ) | ||
| .await | ||
| .expect_err("missing Cloudflare account should fail before network call"); |
There was a problem hiding this comment.
Isolate Cloudflare test from ambient account-id env
This test assumes test_provider(..., None, None) always fails before any network call, but make_api_provider_config resolves Cloudflare base URL from CLOUDFLARE_ACCOUNT_ID when account_id is None, so in environments where that variable is set the provider config is valid and the test reaches a real API call path instead of returning the expected setup error. That makes the assertion flaky and environment-dependent; clear or override CLOUDFLARE_ACCOUNT_ID in this test to keep it deterministic.
Useful? React with 👍 / 👎.
Summary
Verification