Skip to content

fix: clarify cloudflare provider failures - #8

Merged
mattbaconz merged 1 commit into
mainfrom
codex/v0.4.6-cloudflare-diagnostics
May 5, 2026
Merged

mattbaconz merged 1 commit into
mainfrom
codex/v0.4.6-cloudflare-diagnostics

Conversation

@mattbaconz

Copy link
Copy Markdown
Contributor

Summary

  • report missing Cloudflare Account ID / Workers AI base URL in Settings tests instead of unknown provider cloudflare
  • show failed-goal reasons in the Active panel after a run stops
  • bump release metadata to v0.4.6

Verification

  • cargo fmt --all -- --check
  • cargo clippy --locked --workspace --all-targets -- -D warnings
  • cargo test --locked --workspace
  • cargo build --release --locked -p phonton-cli
  • .\target\release\phonton.exe version -> phonton 0.4.6

@mattbaconz
mattbaconz merged commit 963d129 into main May 5, 2026
1 check passed
@mattbaconz
mattbaconz deleted the codex/v0.4.6-cloudflare-diagnostics branch May 5, 2026 17:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa6052e566

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread phonton-cli/src/main.rs
Comment on lines +5990 to +5994
None,
None,
)
.await
.expect_err("missing Cloudflare account should fail before network call");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Isolate Cloudflare test from ambient account-id env

This test assumes test_provider(..., None, None) always fails before any network call, but make_api_provider_config resolves Cloudflare base URL from CLOUDFLARE_ACCOUNT_ID when account_id is None, so in environments where that variable is set the provider config is valid and the test reaches a real API call path instead of returning the expected setup error. That makes the assertion flaky and environment-dependent; clear or override CLOUDFLARE_ACCOUNT_ID in this test to keep it deterministic.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant