[rwo-trackunit]

Description

The chart's Deployment currently always uses the Kubernetes default rollout behavior and exposes no knobs to control it. Because OpenFGA pods typically become Ready within seconds, a rolling update replaces every replica almost simultaneously — so all pods start with cold in-memory caches (check query cache, iterator cache) at the same moment, causing a datastore load spike right after every deployment.

This PR exposes two standard Deployment fields as chart values:

• minReadySeconds (default: unset) — rendered as spec.minReadySeconds when set. Lets operators space out pod replacement so each new pod serves (and warms its cache with) live traffic before the next pod is replaced, keeping at most one cold-cache pod in rotation at a time.
• deploymentStrategy (default: {}) — passed through verbatim as spec.strategy when set. Lets operators tune maxSurge/maxUnavailable or use Recreate.

Both are optional and omitted by default, so rendered manifests are unchanged for existing users.

Changes

• templates/deployment.yaml: render minReadySeconds (guarded with ne ... nil so an explicit 0 renders, matching the existing falsy-numeric handling) and strategy
• values.yaml + values.schema.json: document the new values (minReadySeconds as integer|null, deploymentStrategy as object)
• tests/deployment_strategy_test.yaml: helm-unittest coverage — unset (omitted), 0, positive value, RollingUpdate passthrough, Recreate
• Chart.yaml: bump version to 0.3.17

🤖 Generated with Claude Code

Real life implications

For our usage, we're seeing connection storm at the time of deployment. To be fair, the same could happen under extreme heavy load, where every single call misses the cache. So this is supporting cost-saving, where we rightsize the deployment based on actual usage, but that "actual usage" becomes worst case during deployments.
deploymentStrategy is only added as due-diligence, for future possible deployment tweaks. Let me know if we want to omit that for now.

Summary by CodeRabbit

• New Features

  • Added Helm chart options for configuring minimum ready time and deployment strategy, including RollingUpdate and Recreate modes.
  • Deployment settings are applied only when configured, preserving existing defaults.

• Documentation

  • Updated the chart version to 0.3.17.

• Tests

  • Added coverage for deployment strategy and minimum ready time configurations, including zero-value and omitted settings.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1ba2435b-cd19-4822-abd6-5dbc11407e81

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

Adds configurable minReadySeconds and deploymentStrategy values to the OpenFGA Helm chart, renders them conditionally in Deployments, adds coverage for supported configurations, and bumps the chart version to 0.3.11.

Changes

Deployment rollout configuration

Layer / File(s)	Summary
Rollout value contract charts/openfga/values.yaml, charts/openfga/values.schema.json	Defines default values and schema entries for minReadySeconds and deploymentStrategy.
Deployment rendering and validation charts/openfga/templates/deployment.yaml, charts/openfga/tests/deployment_strategy_test.yaml, charts/openfga/Chart.yaml	Conditionally renders rollout settings, tests default and configured values, and updates the chart version to 0.3.11.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant HelmValues
  participant DeploymentTemplate
  participant KubernetesDeployment
  HelmValues->>DeploymentTemplate: provide rollout values
  DeploymentTemplate->>KubernetesDeployment: render minReadySeconds and strategy

Loading

Possibly related PRs

• openfga/helm-charts#322: Updates the same chart version field in the preceding chart release.

Pre-merge checks | 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main changes: adding passthrough support for minReadySeconds and deploymentStrategy.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rwo-trackunit / name: Roland Wolf (8b577d2)

[rwo-trackunit]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[rwo-trackunit]

Tangentially related to #293, but not quite the same.

[Copilot]

Pull request overview

This PR adds configurable Kubernetes Deployment rollout controls to the openfga Helm chart by exposing spec.minReadySeconds and spec.strategy as values, enabling operators to slow down rollouts and tune surge/unavailable behavior to avoid cache-cold load spikes after deployments.

Changes:

• Add minReadySeconds (optional, supports explicit 0) and deploymentStrategy passthrough values.
• Render spec.minReadySeconds and spec.strategy in templates/deployment.yaml only when configured.
• Add helm-unittest coverage for omission, zero/positive minReadySeconds, and RollingUpdate/Recreate strategy passthrough; bump chart version.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
charts/openfga/values.yaml	Adds new top-level chart values for rollout controls.
charts/openfga/values.schema.json	Documents and constrains the new values via JSON schema.
charts/openfga/templates/deployment.yaml	Conditionally renders spec.minReadySeconds and spec.strategy into the Deployment.
charts/openfga/tests/deployment_strategy_test.yaml	Adds unit tests covering rendering/omission behavior and passthrough semantics.
charts/openfga/Chart.yaml	Bumps chart version to 0.3.11.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[rwo-trackunit]

@Siddhant-K-code Can you have a look if this issue is acceptable after recent changes?

[Siddhant-K-code]

Approving, prior feedback is addressed & all checks pass.

I'll wait for another review someone from @openfga/backend

[rwo-trackunit]

It seems this change has little interest, so closing it.
We can solve the same issue by modifying the resulting deployment "in transit".

[SoulPancake]

Thanks a lot for reopening this and being patient with us @rwo-trackunit!

Some small suggestions:

Since deploymentStrategy goes straight through to spec.strategy, a typo like type: RollingUpdates or rollingupdate: won't get caught until it hits the cluster. Might be worth typing it in the schema so helm template catches it instead, something like:

"properties": {
  "type": { "type": "string", "enum": ["RollingUpdate", "Recreate"] },
  "rollingUpdate": {
    "type": "object",
    "properties": {
      "maxSurge": { "type": ["integer", "string"] },
      "maxUnavailable": { "type": ["integer", "string"] }
    },
    "additionalProperties": false
  }
},
"additionalProperties": false

Also on the two reject tests, failedTemplate: {} passes on any render error, so adding an errorPattern would make sure they're actually failing on the schema check:

- failedTemplate:
    errorPattern: minReadySeconds

Let me know what you think!

[rwo-trackunit]

Thanks a lot for reopening this and being patient with us @rwo-trackunit!

Some small suggestions:

Since deploymentStrategy goes straight through to spec.strategy, a typo like type: RollingUpdates or rollingupdate: won't get caught until it hits the cluster. Might be worth typing it in the schema so helm template catches it instead, something like:

"properties": {
  "type": { "type": "string", "enum": ["RollingUpdate", "Recreate"] },
  "rollingUpdate": {
    "type": "object",
    "properties": {
      "maxSurge": { "type": ["integer", "string"] },
      "maxUnavailable": { "type": ["integer", "string"] }
    },
    "additionalProperties": false
  }
},
"additionalProperties": false

Also on the two reject tests, failedTemplate: {} passes on any render error, so adding an errorPattern would make sure they're actually failing on the schema check:

- failedTemplate:
    errorPattern: minReadySeconds

Let me know what you think!

Agree on all points. This should be mitigated now.

[SoulPancake]

thanks a lot @rwo-trackunit <3

[SoulPancake]

LGTM 🚀