Repository navigation
fix(ci): support immutable releases in chart release workflow - #364
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
| Layer / File(s) | Summary |
|---|---|
Release metadata and action charts/openfga/Chart.yaml, .github/workflows/release.yml |
The chart version changes to 0.3.19. The release workflow uses chart-releaser-action v1.8.0. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Possibly related PRs
- openfga/helm-charts#327: Adds
minReadySecondsanddeploymentStrategyvalues and templates that are described as shipping with chart version 0.3.19.
Suggested reviewers: siddhant-k-code, vic-dev
Merge Risk: 
c784f
-
The release metadata and action updates are consistent with the intended immutable-release fix and are ready to merge.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title names the main change: the chart release workflow is updated so immutable GitHub releases work. The raw summary lists only the chart-releaser-action bump and the chart version bump, and the … Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the main change: the chart release workflow is updated so immutable GitHub releases work. The raw summary lists only the chart-releaser-action bump and the chart version bump, and the objectives confirm that the action bump is the fix for immutable-release asset uploads. The title is specific and matches the changeset. The 'fix(ci)' prefix follows conventional commit style.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
GitHub immutable releases were enabled for this repo between the openfga-0.3.16 (Oct 6) and openfga-0.3.17 (Oct 29) releases. The chart-releaser v1.7.0 flow (create published release, then upload assets) now fails with: 422 Cannot upload assets to an immutable release leaving openfga-0.3.17 and openfga-0.3.18 as published, immutable, asset-less releases that never reached the helm repo index or GHCR. Changes: - Bump helm/chart-releaser-action to v1.8.0 (chart-releaser v1.9.0), which creates the release as a draft, uploads assets, and only then publishes (helm/chart-releaser#587), compatible with immutable releases. Verified end-to-end against a repository with immutable releases enabled: release published with assets attached. - Bump chart to 0.3.19: the 0.3.17/0.3.18 releases and tags are immutable (tags cannot be deleted or moved) and CR_SKIP_EXISTING skips them, so a new version is required for the next release to ship. 0.3.19 carries the previously unreleased changes (OpenFGA v1.22.1, minReadySeconds/deploymentStrategy). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
c784ff9 to
c6168cf
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the immutable-release publishing update and chart version bump.
No open issues 🎉
What changed in this PR
Updates chart publishing to support GitHub immutable releases and advances the chart version so previously unreleased content can be published under a new tag.
Changes:
- Upgrades the pinned chart-releaser action from v1.7.0 to v1.8.0, enabling asset uploads before release publication.
- Bumps the chart from 0.3.18 to 0.3.19 to avoid the existing immutable releases.
| File | Description |
|---|---|
charts/openfga/Chart.yaml |
Advances the chart version to 0.3.19. |
.github/workflows/release.yml |
Updates the pinned chart-releaser action for immutable-release support. |
Review effort: Balanced
Problem
The last two release runs failed (0.3.17, 0.3.18) with:
Root cause: GitHub immutable releases were enabled for this repo between the 0.3.16 (Oct 6,
immutable: false) and 0.3.17 (Oct 29,immutable: true) releases. chart-releaser v1.7.0 creates the release published-first, then uploads the.tgz— immutable releases reject any asset upload after publish. Result:openfga-0.3.17andopenfga-0.3.18exist as published, empty releases (no chart assets), never reachedindex.yamlor GHCR. Not related to the runner image migration.Fix
helm/chart-releaser-actionv1.7.0 → v1.8.0 (chart-releaser v1.9.0), which creates the release as a draft, uploads assets, then publishes — explicitly supporting immutable releases (fix: support repositories with immutable releases enabled helm/chart-releaser#587, Incompatibility with GitHub immutable releases helm/chart-releaser#591). Same draft→publish pattern as our org'sundraft-release.yml.CR_SKIP_EXISTINGskips them — so the next release must be a new version. 0.3.19 ships the previously unreleased content (OpenFGA v1.22.1,minReadySeconds/deploymentStrategy).Both changes are intentionally in one PR: merging the version bump without the action bump would mint another empty immutable release; merging the action bump alone releases nothing (0.3.18 is skipped as existing).
Verification
Tested chart-releaser v1.9.0
uploadend-to-end against a repository with immutable releases enabled — the release was published with the chart asset attached:{"draft": false, "immutable": true, "assets": [{"name": "crtest-0.0.1-crtest.tgz", "size": 4922, "state": "uploaded"}]}Also:
helm lintclean, 34/34 unit tests pass, workflow YAML validated.After merge
openfga-0.3.19with assets, updatesindex.yaml, pushes to GHCR.