Repository navigation
feat: allow static roles with empty permission lists - #548
mariajgrimaldi wants to merge 2 commits into
Conversation
|
Thanks for the pull request, @mariajgrimaldi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Thanks for the pull request, @mariajgrimaldi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
a58e779 to
4b7941a
Compare
2a46954 to
6d9725b
Compare
6d9725b to
691dbf6
Compare
691dbf6 to
d23f249
Compare
d23f249 to
d7c8a56
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d7c8a56 to
bd31034
Compare
Description
Under ADR 0033, course-team roles live in the shared
course_team_rolesapplet because they cut across several contexts, while other applets add the permissions they own through role extensions.course_editorandcourse_auditortherefore have empty base definitions in #550, since all their current permissions come fromcourse_authoring, and the published JSON Schema rejects that empty list even though the Python validation, compiler, and renderer already accept it.This PR allows an empty
permissionslist in role definitions, whileadd_permissionsandremove_permissionsinrole_extensionsstay non-empty, and addsjsonschemaas a test dependency to check both rules.Merge checklist:
Check off if complete or not applicable: