Skip to content

feat: allow static roles with empty permission lists - #548

Open
mariajgrimaldi wants to merge 2 commits into
MJG/applets-adrfrom
MJG/applets-composable-roles
Open

mariajgrimaldi wants to merge 2 commits into
MJG/applets-adrfrom
MJG/applets-composable-roles

Conversation

@mariajgrimaldi

@mariajgrimaldi mariajgrimaldi commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Description

Under ADR 0033, course-team roles live in the shared course_team_roles applet because they cut across several contexts, while other applets add the permissions they own through role extensions. course_editor and course_auditor therefore have empty base definitions in #550, since all their current permissions come from course_authoring, and the published JSON Schema rejects that empty list even though the Python validation, compiler, and renderer already accept it.

This PR allows an empty permissions list in role definitions, while add_permissions and remove_permissions in role_extensions stay non-empty, and adds jsonschema as a test dependency to check both rules.

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 21, 2026
@openedx-webhooks

openedx-webhooks commented Oct 21, 2026 •

Copy link
Copy Markdown

Thanks for the pull request, @mariajgrimaldi!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @mariajgrimaldi!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Oct 21, 2026
@mariajgrimaldi
mariajgrimaldi changed the base branch from main to MJG/applets-adr October 21, 2026 13:38
@mariajgrimaldi
mariajgrimaldi added this pull request to stack #549 October 21, 2026 13:45
@mariajgrimaldi
mariajgrimaldi force-pushed the MJG/applets-composable-roles branch 2 times, most recently from a58e779 to 4b7941a Compare October 21, 2026 19:33
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Oct 22, 2026
@mariajgrimaldi
mariajgrimaldi force-pushed the MJG/applets-composable-roles branch 2 times, most recently from 2a46954 to 6d9725b Compare October 23, 2026 10:33
@mariajgrimaldi
mariajgrimaldi force-pushed the MJG/applets-composable-roles branch from 6d9725b to 691dbf6 Compare October 23, 2026 10:53
@mariajgrimaldi
mariajgrimaldi force-pushed the MJG/applets-composable-roles branch from 691dbf6 to d23f249 Compare October 23, 2026 12:02
@mariajgrimaldi
mariajgrimaldi marked this pull request as ready for review October 23, 2026 12:06
@mariajgrimaldi mariajgrimaldi linked an issue Oct 23, 2026 that may be closed by this pull request
4 tasks
@mariajgrimaldi
mariajgrimaldi force-pushed the MJG/applets-composable-roles branch from d23f249 to d7c8a56 Compare October 23, 2026 13:00
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mariajgrimaldi
mariajgrimaldi force-pushed the MJG/applets-composable-roles branch from d7c8a56 to bd31034 Compare October 23, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

Register Instructor Dashboard permissions in AuthZ (LMS)

3 participants