Repository navigation
fix: stop hardcoding manifest's "." key; dedupe linked-versions changelog repeats - #21
Merged
Merged
Conversation
…hangelog repeats Both bugs surfaced setting up release-please-forecast against a Cargo workspace using the cargo-workspace + linked-versions plugins (per-member packages, no "." package at all). - current_version/candidate read .release-please-manifest.json at "." unconditionally, so a manifest keyed by package path instead comes back empty with no indication anything went wrong. Add a package-name input to name the key explicitly, falling back to the manifest's first key (right for a linked-versions group with merge: true, wrong otherwise — preflight now warns when this fallback is in effect). - The preview comment repeated the same changelog body once per linked package, since linked-versions with merge: true still appears to walk one release candidate per component internally before printing a single combined update count. Collapse immediately-repeated identical <details> blocks defensively, regardless of root cause. Fixes #20.
Contributor
🤖 release-please PREVIEWWhat merging this PR into 🤖 I will create a release beep boop1.5.1 (2026-09-26)Bug Fixes
This PR was generated with Release Please. See documentation. Two entries, one change: release-please reads both the commit on this branch and the merge commit GitHub will create, whose body is this PR title. Both really do land in the published changelog. Only the merge commit has no SHA to cite, because it does not exist yet. Predicted from |
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20.
Both bugs were found setting up release-please-forecast against a Cargo
workspace using the
cargo-workspace+linked-versionsplugins(per-member
packagesentries, no"."package at all — seenon7top/sort4print#38).
1.
current_version/candidateno longer hardcode.They previously read
.release-please-manifest.jsonat the"."keyunconditionally. A manifest keyed by package path instead (e.g.
core,app,tools/pack-cities) silently came back empty, degradingbump_typeclassification and theunreliable_reasongating withouterroring.
Added a
package-nameinput to name the manifest key explicitly. Absentthat, it falls back to the manifest's first key — correct when every
package is kept in lockstep by a
linked-versionsgroup withmerge: true, wrong for independently-released packages. Preflight nowwarns whenever that fallback is in effect, since it can't tell from the
manifest alone whether the packages are actually linked.
2. Preview comment no longer repeats the changelog body per linked-versions component
Traced to
linked-versionswithmerge: trueapparently still walkingone release candidate per linked package internally, each wrapped in an
identical
<details><summary>version</summary>…</details>block, beforeprinting a single combined
updates: Nline — so the body alreadycontained the block repeated once per package. Added a defensive
post-process step that collapses immediately-repeated identical
<details>blocks, regardless of root cause.Verified both fixes with a local git/jq/awk simulation reproducing the
manifest shape and comment body from the linked issue, and confirmed a
regression check that ordinary single-package output passes through the
new dedup step byte-for-byte unchanged.
Test plan
bash -nover every composite-actionrun:stepmanifest_versionkey resolution (.present,.absent with fallback, explicit
package-nameoverride, emptymanifest) against representative JSON
repo (manifest keyed by
core/app/tools/pack-cities,preview-baseat0.1.0→preview-headat0.5.0) and confirmedcurrent_version/candidatenow resolve instead of coming backempty
awkagainst the actual duplicated comment body fromfix(release): use cargo-workspace + linked-versions plugins sort4print#38 (issuecomment-5844317139) and confirmed it
collapses to one block
awkis a no-op (byte-identical output) on areal single-package changelog sample from this repo's own history
conventional-commit) passed on the commit