Repository navigation
feat: pass a package-name input through to release-please-forecast - #1
Merged
Merged
Conversation
release-please-forecast (non7top/release-please-forecast#21) added a package-name input so it can classify the predicted bump against a manifest keyed by package path instead of ".", which a cargo-workspace + linked-versions setup produces. This reusable workflow hardcoded no such input, so a caller had no way to set it. Thread it through.
non7top
added a commit
to non7top/sort4print
that referenced
this pull request
Sep 26, 2026
Our manifest has no "." key since #37/this PR moved to the cargo-workspace + linked-versions plugins, so release-please-forecast was falling back to guessing the manifest's first key and preflight-warning about it on every preview (non7top/release-please-forecast#20, see #38 (comment)). The guess happens to be right here, since linked-versions with merge: true keeps core/app/tools/pack-* at one version, but naming it explicitly turns that guess into a stated fact instead. Needs non7top/gh-workflows#1 merged to take effect — release-please-preview.yml@main doesn't accept a package-name input yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-please-forecast added a
package-nameinput innon7top/release-please-forecast#21, letting a caller name which
.release-please-manifest.jsonkey holds the version to classify thepredicted bump against — needed for a manifest keyed by package path
(release-please's
cargo-workspace/linked-versionsplugins) instead of..This reusable workflow called that action with no way for a caller to set
it. Threaded a
package-nameinput through to the action call, defaultingto empty (unchanged behavior for every existing caller).
Needed by non7top/sort4print#38, which switched to a per-package manifest
and currently has no way to silence release-please-forecast's preflight
warning about guessing the version from the manifest's first key.