Repository navigation
Restore conditional Cache-Control header - #1403
Merged
Merged
Conversation
"Clarify default Cache-Control header" (c39ec5a) wrongly assumed that this setting is the baseline that is overridden by other handlers. It turns out that Next.js and `expressStaticGzip` (used for Auspice assets) only set their defaults when Cache-Control has not already been set. Ignore the claim in the previous commit message. Two wrongs make a right?
2 tasks done
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1402 wrongly assumed that this setting is the baseline that is overridden by other handlers. It turns out that Next.js and
expressStaticGzip(used for Auspice assets) only set their defaults when Cache-Control has not already been set.Ignore the claim in the previous commit message. Two wrongs make a right?
(Sorry for the PR spam. Cache control headers only apply in production and I've been testing on the canary site out of convenience.)
Checklist