Repository navigation
Clarify default Cache-Control header - #1402
Merged
Merged
Conversation
"Prevent CDN caching on most routes" (9e16e78) wrongly assumed that this setting took precedence over other handlers. In fact it's the other way around – this is the baseline that is overridden by other handlers. Updated the comment and simplified the logic.
victorlin
commented
Oct 26, 2026
| * Specific handlers (e.g. for static assets) can override this. | ||
| */ | ||
| app.use((req, res, next) => { | ||
| if (!req.path.startsWith("/_next/static/") && !req.path.startsWith("/dist/")) { |
Member
Author
There was a problem hiding this comment.
For context, pages/assets through Next.js are handled externally and Auspice is handed here:
nextstrain.org/src/endpoints/auspice.js
Line 21 in c39ec5a
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1401 wrongly assumed that this setting took precedence over other handlers. In fact it's the other way around – this is the baseline that is overridden by other handlers.nevermind... see #1403Checklist