Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a0cd49-e225-7475-a033-acae829bfdc5 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0cd49-e225-7475-a033-acae829bfdc5 Co-authored-by: Amp <amp@ampcode.com>
Make namespace roots, blob-directory coexistence, and permanent error classification consistent across storage backends and SDKs. Add backend matrix and durable host regression coverage. Amp-Thread-ID: https://ampcode.com/threads/T-01a0cd49-e92a-719f-b761-edfda02b7fe7 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0cd49-e92a-719f-b761-edfda02b7fe7 Co-authored-by: Amp <amp@ampcode.com>
|
Review of 46a1bc2. The mistake here is ours, not yours. GOL-622 and GOL-627 should have said to start only after the
This PR started from main without that, so it rebuilt part of the same contract under the same type names, with different rules in places. Merging the two now gives about 90 conflict hunks and a few breaks that merge cleanly and fail later. Please hold this PR until the blob storage part of Keep:
Drop, because
Code on the branch that the new layout breaks without a conflict:
Three issues in the PR itself, which apply either way:
Once it's rebased, I'd also move the coexistence scenarios off the MinIO dimension and onto the scripted S3 transport in Sorry for the extra work. The fs and SQLite parts are what we need, and they carry over. |
|
Thanks for the detailed review. We’ll keep this PR open and hold off on rebasing or further changes until the |
f905f1f to
2a4a400
Compare
Summary
Test coverage
cargo clippy -p golem-service-base -p golem-worker-executor --all-targets --no-deps -- -D warningsDependency
This PR is stacked on #3945 so the shared MinIO test-framework refactor lands first. It can be retargeted to
mainafter #3945 merges.Resolves GOL-622
Resolves GOL-627