Conversation
✅ Deploy Preview for golemcloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Review of dca0aae. The fix is correct. Two changes before it lands:
Also:
|
dca0aae to
8ac8490
Compare
Amp-Thread-ID: https://ampcode.com/threads/T-01a0cd49-f13e-729b-9560-22c08702c07c Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0cd49-f13e-729b-9560-22c08702c07c Co-authored-by: Amp <amp@ampcode.com>
8ac8490 to
45142d4
Compare
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a0cd49-f13e-729b-9560-22c08702c07c
45142d4 to
e32e53a
Compare
|
Review of e32e53a. Thank you, this now covers all of GOL-635. Root object names are rejected with a permanent Since this is stacked on #3947, which waits for the Two notes I'll carry into the takeover, for the record:
|
Amp-Thread-ID: https://ampcode.com/threads/T-01a0cd49-f13e-729b-9560-22c08702c07c Co-authored-by: Amp <amp@ampcode.com>
|
@kmatasfp Thanks. One correction for the takeover: the nameless-listing error does not currently retry. I agreed with the absolute-object-name integration safeguard and pushed 36e28d5: |
Summary
InvalidInputerrors across blobstore writes, deletes, checks, metadata, copy, and move operationsget_data(container, root)read behavior while validating both object endpoints and every batch-delete name before mutationlist_objectspath-name unwrap with an error path and cover it through the serviceDependency
This PR is stacked on #3947, which provides the backend and root-container contract prerequisites from GOL-622/GOL-627. It should be reviewed and landed after that PR.
Verification
cargo fmt -p golem-worker-executor -- --checkcargo clippy -p golem-worker-executor --lib --tests --no-deps -- -D warningscargo test -p golem-worker-executor --lib -- services::blob_store::tests --report-timecargo test -p golem-worker-executor --test integration -- blobstore_rejects_root_container_names_without_retrying blobstore_rejects_root_object_names_without_hiding_the_container --report-timeResolves GOL-635