Repository navigation
test: clarify error messages in isMethodAllowed tests - #42
Krishnanand-G wants to merge 1 commit into
Conversation
b5442f6 to
37c2d28
Compare
37c2d28 to
39eaac6
Compare
|
Thanks for the approval @VojtechVitek. Happy to squash/rebase if needed — could this be merged when you have a minute? |
|
@pkieltyka this got an approval from @VojtechVitek a while back. Mind merging when you get a sec? Happy to squash if needed. |
|
This is approved but blocked on CI. The 1.22.x macos-latest job failed on a runner issue (dyld: missing LC_UUID load command), which triggered fail-fast and cancelled the other macOS/Windows jobs. Ubuntu passed on all versions, and the failure isn't related to this change. Could someone with admin rights re-run the failed jobs? |
|
I tried to rerun the failed jobs, but GitHub requires repository admin rights to do that. The previous failures were runner errors rather than test failures, and the PR is already approved. Could a maintainer rerun the workflow when convenient? |
Summary
Closes #28.
TestDefaultalready uses the correctedmust not be nilmessages on master. This PR fixes the remaining misleading failure messages in the same file:TestIsMethodAllowedReturnsFalseWithNoMethods: the test setsallowedMethodsto an empty slice, not nilTestIsMethodAllowedReturnsTrueWithOptions: describes the actual assertion (OPTIONS allowed with default options)Test plan
go test ./...go vet ./...