Repository navigation
Fixed error messages in TestDefault #28
Description
A partial code of cors_test.go is shown below.
if s.allowedHeaders == nil {
t.Error("c.allowedHeaders should be nil when Default")
}
if s.allowedMethods == nil {
t.Error("c.allowedMethods should be nil when Default")
}We believe the following message is appropriate for this.
if s.allowedHeaders == nil {
t.Error("c.allowedHeaders must not be nil when Default")
}
if s.allowedMethods == nil {
t.Error("c.allowedMethods must not nil when Default")
}
Activity
fix test_default error message go-chi#28
fix test_default error message #28 (#29)
Krishnanand-G commentedon Jun 29, 2026
Opened PR #42 to close this. TestDefault already had the corrected messages on master; the PR fixes the remaining misleading error messages in TestIsMethodAllowedReturnsFalseWithNoMethods and TestIsMethodAllowedReturnsTrueWithOptions.
test: clarify error messages in isMethodAllowed tests (closes go-chi#28)
test: clarify error messages in isMethodAllowed tests (closes go-chi#28)
test: clarify error messages in isMethodAllowed tests (closes go-chi#28)