Skip to content

ref(tracing): Remove unused get_url_attributes_legacy #8156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 1 commit into from
Oct 29, 2026
+0 −33
Merged

ref(tracing): Remove unused get_url_attributes_legacy #8156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions sentry_sdk/tracing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,39 +166,6 @@ def add_http_breadcrumb(status_code: "Optional[int]", data: "dict[str, Any]") ->
sentry_sdk.add_breadcrumb(**kwargs)


def get_url_attributes_legacy(
client: "sentry_sdk.client.BaseClient",
parsed_url: "Optional[ParsedUrl]",
) -> "Attributes":
"""Build the `url.*` span attributes for an outgoing HTTP request.

The query string is filtered according to `data_collection`.
"""
attributes: "Attributes" = {}
if parsed_url is None:
return attributes

query: "Optional[str]" = None
if parsed_url.query:
query = _apply_data_collection_filtering_to_query_string(
query_string=parsed_url.query,
behaviour=client.options["data_collection"]["url_query_params"],
)

url_full = parsed_url.url
if query:
attributes[SPANDATA.URL_QUERY] = query
url_full += "?" + query

if parsed_url.fragment:
attributes[SPANDATA.URL_FRAGMENT] = parsed_url.fragment
url_full += "#" + parsed_url.fragment

attributes[SPANDATA.URL_FULL] = url_full

return attributes


def get_url_attributes(
client: "sentry_sdk.client.BaseClient",
parsed_url: "Optional[ParsedUrl]",
Expand Down
Loading