Skip to content

ref(tracing): Remove unused get_url_attributes_legacy - #8156

Merged
sentrivana merged 1 commit into
major/3.0from
ivana/remove-get-url-attributes-legacy
Oct 29, 2026
Merged

sentrivana merged 1 commit into
major/3.0from
ivana/remove-get-url-attributes-legacy

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Description

Removes get_url_attributes_legacy() from sentry_sdk/tracing_utils.py. Nothing on major/3.0 calls it anymore.

Its callers were the outgoing HTTP client integrations (pyreqwest, httpx, httpx2). It handled their old send_default_pii behavior. When #7698, #7819 and #7830 dropped send_default_pii support from those integrations, each one removed its calls and switched to get_url_attributes(). The legacy helper was left behind.

Evidence

  • On major/3.0, git grep -w get_url_attributes_legacy matches only the definition. There are no callers in sentry_sdk, tests, scripts or docs.
  • No open PR mentions it. The function doesn't exist on master, so a future master → major/3.0 merge can't bring it back.

get_url_attributes() and _apply_data_collection_filtering_to_query_string are still used, so they stay.

Issues

n/a

via Ivana Kellyer.

--

View Junior Session [Sentry]

Co-Authored-By: Ivana Kellyer <ivana.kellyer@sentry.io>
@sentry-junior
sentry-junior Bot requested a review from a team as a code owner October 29, 2026 11:56
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 57523 passed | ⏭️ 2979 skipped | Total: 60502 | Pass Rate: 95.08% | Execution Time: 159m 17s

All tests are passing successfully.

✅ Patch coverage is 100.00% (no changed executable lines found; target 80%).
Project statement coverage is 90.27% (down 0.05 percentage points from base (3668ba4) to head (990b90f)).

Files with missing lines (1)
File Coverage % Lines
sentry_sdk/tracing_utils.py 90.97% ⚠️ 54 Missing and 32 partials
Coverage diff
@@            Coverage Diff             @@
##        master     #8156       +/-##
==========================================
- Coverage    90.32%    90.27%    -0.05%
==========================================
  Files          203       198        -5
  Tracked lines     26872     21285     -5587
  Branches     10044      7370     -2674
==========================================
- Hits         24272     19215     -5057
+ Misses        2600      2070      -530
+ Partials      1520      1237      -283

Generated by Coverage Action

@sentrivana
sentrivana merged commit e0a5492 into major/3.0 Oct 29, 2026
430 of 435 checks passed
@sentrivana
sentrivana deleted the ivana/remove-get-url-attributes-legacy branch October 29, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant