Repository navigation
ref(tracing): Remove unused get_url_attributes_legacy - #8156
Merged
Merged
Conversation
Co-Authored-By: Ivana Kellyer <ivana.kellyer@sentry.io>
sentrivana
approved these changes
Oct 29, 2026
Contributor
Coverage Results 📊✅ 57523 passed | ⏭️ 2979 skipped | Total: 60502 | Pass Rate: 95.08% | Execution Time: 159m 17s All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 80%). Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## master #8156 +/-##
==========================================
- Coverage 90.32% 90.27% -0.05%
==========================================
Files 203 198 -5
Tracked lines 26872 21285 -5587
Branches 10044 7370 -2674
==========================================
- Hits 24272 19215 -5057
+ Misses 2600 2070 -530
+ Partials 1520 1237 -283Generated by Coverage Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
get_url_attributes_legacy()fromsentry_sdk/tracing_utils.py. Nothing onmajor/3.0calls it anymore.Its callers were the outgoing HTTP client integrations (pyreqwest, httpx, httpx2). It handled their old
send_default_piibehavior. When #7698, #7819 and #7830 droppedsend_default_piisupport from those integrations, each one removed its calls and switched toget_url_attributes(). The legacy helper was left behind.Evidence
major/3.0,git grep -w get_url_attributes_legacymatches only the definition. There are no callers insentry_sdk,tests,scriptsordocs.master, so a futuremaster→major/3.0merge can't bring it back.get_url_attributes()and_apply_data_collection_filtering_to_query_stringare still used, so they stay.Issues
n/a
via Ivana Kellyer.
--
View Junior Session [Sentry]