Repository navigation
docs: pipeline: outputs: syslog: remove unreleased framing and sd preset docs - #2728
Conversation
…set docs
- Remove the syslog_framing row from the configuration parameters
table and delete the Message framing section.
- Remove the syslog_sd_preset row from the configuration parameters
table and delete the Structured data preset section.
- Restore the Add structured data authentication token section, minus
its cross-reference to the now-absent preset section. The Lua filter
is the only approach available in released versions.
Neither syslog_framing nor syslog_sd_preset is present in v5.1.2 or
earlier; both landed on fluent-bit master after that tag. Re-add both,
and drop the Lua authentication token example, in the release that
carries them.
Refs fluent#2727
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe Syslog output documentation removes the ChangesSyslog output documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to No issue requiring a fix before merge is established by the supplied context. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@sigJoe please review this PR. |
|
@eschabell LGTM, but I'm not a maintainer and cannot formally review or approve. I'm just a user with emotional investment in this particular feature |
…age (#2729) - Remove the Syslog output octet counting framing entry. PR #2728 removed syslog_framing from pipeline/outputs/syslog.md as unreleased, leaving this entry pointing at a parameter no page documents. - Gate the GCS total_file_size upload trigger as v5.1.3 and greater. The GCS output ships in v5.1, but the size trigger is not in v5.1.2. Signed-off-by: Eric D. Schabell <eric@schabell.org>
Neither syslog_framing nor syslog_sd_preset is present in v5.1.2 or
earlier; both landed on fluent-bit master after that tag. Re-add both,
and drop the Lua authentication token example, in the release that
carries them.
Refs #2727
Signed-off-by: Eric D. Schabell eric@schabell.org
Summary by CodeRabbit