Skip to content

docs: installation: whats-new: correct unreleased content on the v5 page - #2729

Merged
eschabell merged 1 commit into
fluent:masterfrom
eschabell:docs-whatsnew-unreleased-content
Sep 26, 2026
Merged

eschabell merged 1 commit into
fluent:masterfrom
eschabell:docs-whatsnew-unreleased-content

Conversation

@eschabell

@eschabell eschabell commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

  - Remove the Syslog output octet counting framing entry. PR fluent#2728
    removed syslog_framing from pipeline/outputs/syslog.md as unreleased,
    leaving this entry pointing at a parameter no page documents.
  - Gate the GCS total_file_size upload trigger as v5.1.3 and greater.
    The GCS output ships in v5.1, but the size trigger is not in v5.1.2.

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell
eschabell requested review from a team and patrick-stephens as code owners September 25, 2026 18:12
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: de5d84cd-499e-4d43-b334-a4efd1a86a2e

📥 Commits

Reviewing files that changed from the base of the PR and between ca2da90 and 0f3be2a.

📒 Files selected for processing (1)
  • installation/whats-new-in-fluent-bit-v5.md

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The Fluent Bit v5 release notes now qualify the Google Cloud Storage total_file_size upload trigger as applying to version 5.1.3 and later. The Syslog octet-counting framing entry was removed.

Changes

Fluent Bit v5 release notes

Layer / File(s) Summary
Release-note updates
installation/whats-new-in-fluent-bit-v5.md
The Google Cloud Storage description specifies that total_file_size triggers an upload in Fluent Bit 5.1.3 and later. The Syslog octet-counting framing entry was removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 0f3be

The Syslog release-note removal is accurate. The GCS note clarifies a version limit, though its exact threshold remains unconfirmed; no concrete user-impacting failure is established, so merge risk is minimal.

Architecture Summary

Architecture risk: 🔵 Low · up to 0f3be

The change affects 1 system.

Changed systems: installation

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — installation (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in installation/whats-new-in-fluent-bit-v5.md: The GCS description now limits the total_file_size upload trigger to Fluent Bit 5.1.3 and later; previously, it was presented without a version qualification. The upload_timeout trigger is unchanged.
  • observed — Modified behavior in installation/whats-new-in-fluent-bit-v5.md: The Syslog octet-counting framing entry, including its syslog_framing setting and supported tcp/tls modes, was removed.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies a documentation update that corrects unreleased content on the Fluent Bit v5 What’s New page. It covers both the Syslog removal and the GCS version clarification.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eschabell eschabell self-assigned this Sep 25, 2026
@eschabell eschabell added 5.1.2 waiting-on-review Waiting on a review from mainteners labels Sep 25, 2026
@eschabell

Copy link
Copy Markdown
Collaborator Author

@patrick-stephens ready for review!

@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Sep 26, 2026
@eschabell
eschabell merged commit 03fe339 into fluent:master Sep 26, 2026
8 checks passed
@eschabell
eschabell deleted the docs-whatsnew-unreleased-content branch September 26, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants