Skip to content

feat: DialogPanel 增加 4xl 宽度档 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qqqqqf-q merged 1 commit into from
Oct 9, 2026
Merged

feat: DialogPanel 增加 4xl 宽度档 #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,8 @@ pass with `node scripts/check-ui-contract.mjs --write-baseline`.
corner close in a view-swap dialog lands it ~12px off the title
centerline). Knobs: `width` (mode-scoped default: `2xl` workbench · `xl`
view-swap, whose slim-row list reads sparse a rung wider; `'lg'` one-field
forms · `'3xl'` editor-heavy),
forms · `'3xl'` editor-heavy · `'4xl'` a history rail beside the working
pane),
`grow` (fixed `h-[80dvh]` for bodies with no intrinsic height — editors),
`view-swap` (header is a `DialogViewHeader`, so the built-in corner close
is disabled — the pairing is enforced by the prop, not by memory),
Expand Down
7 changes: 5 additions & 2 deletions src/components/dialog/DialogPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
// - width: panel width rung. Defaults are MODE-SCOPED (see effectiveWidth):
// 2xl for workbench, xl for view-swap; 'lg' for a one-or-two-field form
// (a 2xl panel around one field reads barren); '3xl' for editor-heavy
// bodies (Monaco import).
// bodies (Monaco import); '4xl' for a two-column body — a history rail
// beside the working pane (the feedback dialog), where 3xl minus the rail
// leaves the working pane too narrow to read a conversation.
// - grow: false (default) → max-h-[80dvh], panel hugs its content and the
// cap only bites when content is tall. true → h-[80dvh] fixed — required
// when the body has NO intrinsic height (an editor/iframe that must be
Expand Down Expand Up @@ -47,7 +49,7 @@ const props = withDefaults(defineProps<DialogContentProps & {
class?: HTMLAttributes['class']
/** Panel width rung. Add rungs here deliberately — not per-page.
* Omit to inherit the mode default: 2xl workbench · xl view-swap. */
width?: 'lg' | 'xl' | '2xl' | '3xl'
width?: 'lg' | 'xl' | '2xl' | '3xl' | '4xl'
/** Fixed 80dvh height for bodies with no intrinsic height (editors). */
grow?: boolean
/** View-swap dialog: header is a DialogViewHeader, so the built-in corner
Expand Down Expand Up @@ -78,6 +80,7 @@ const WIDTH = {
'xl': 'sm:max-w-xl',
'2xl': 'sm:max-w-2xl',
'3xl': 'sm:max-w-3xl',
'4xl': 'sm:max-w-4xl',
} as const

// Mode-scoped default width (only when the caller omits `width`):
Expand Down
Loading