Repository navigation
feat: DialogPanel 增加 4xl 宽度档 - #35
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DialogPanel增加width="4xl"(sm:max-w-4xl),给「左侧历史栏 + 右侧工作区」这类双栏对话框用。首个调用方是 Cloud 门户的反馈工单对话框:左栏固定 224px(「新反馈」+ 工单记录),右栏是表单或一段对话。用 3xl 时减去左栏,右栏放不下一段对话。
width类型联合与WIDTH表各加一档,头注释写明适用场景AGENTS.md的 DialogPanel 旋钮说明同步列出4xl影响面
纯新增,没有现有调用方受影响。缺这一档时调用方写
width="4xl"会拿不到max-w,面板在 grid 里被挤成一条竖线——配套的 Cloud PR 合并前,需要先合本 PR。分支从
bdee6f0切出(Memoh-Cloudsubmodule/memoh当前引用的版本),对main没有冲突。Related
packages/ui指针先指向本分支提交,本 PR 合并后改指合并后的提交)Validation
check(vue-tsc --build)失败,报@memohai/icon/ui没有导出ErrorIcon(callout-banner、FieldError、FormMessage、FieldStack四处)。main 从 feat: 把 CalloutBanner 做成唯一的提示面 #31 起每次都以同样的错误失败,与本 PR 改动无关Human QA