Skip to content

feat: DialogPanel 增加 4xl 宽度档 - #35

Merged
qqqqqf-q merged 1 commit into
mainfrom
feat/memoh-102-dialog-panel-4xl
Oct 9, 2026
Merged

qqqqqf-q merged 1 commit into
mainfrom
feat/memoh-102-dialog-panel-4xl

Conversation

@qqqqqf-q

@qqqqqf-q qqqqqf-q commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Summary

DialogPanel 增加 width="4xl"(sm:max-w-4xl),给「左侧历史栏 + 右侧工作区」这类双栏对话框用。

首个调用方是 Cloud 门户的反馈工单对话框:左栏固定 224px(「新反馈」+ 工单记录),右栏是表单或一段对话。用 3xl 时减去左栏,右栏放不下一段对话。

  • width 类型联合与 WIDTH 表各加一档,头注释写明适用场景
  • AGENTS.md 的 DialogPanel 旋钮说明同步列出 4xl
  • 只新增档位,现有档位和各模式的默认宽度不变

影响面

纯新增,没有现有调用方受影响。缺这一档时调用方写 width="4xl" 会拿不到 max-w,面板在 grid 里被挤成一条竖线——配套的 Cloud PR 合并前,需要先合本 PR。

分支从 bdee6f0 切出(Memoh-Cloud submodule/memoh 当前引用的版本),对 main 没有冲突。

Related

Validation

  • 本地 Cloud 开发环境(宿主机 vite → 主槽位 BFF)里把这份改动接到反馈对话框上,用户在浏览器里走查过布局,宽屏下两栏按 4xl 正常展开;没有这一档时同一页面被挤成竖线。未附截图
  • 宿主侧 eslint 通过
  • ui CI 的 check(vue-tsc --build)失败,报 @memohai/icon/ui 没有导出 ErrorIcon(callout-banner、FieldError、FormMessage、FieldStack 四处)。main 从 feat: 把 CalloutBanner 做成唯一的提示面 #31 起每次都以同样的错误失败,与本 PR 改动无关

Human QA

  • Human QA passed

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T22:59:17.918836Z a892de9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@qqqqqf-q
qqqqqf-q merged commit 6b563a2 into main Oct 9, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant