Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/desktop_js_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
deno-version: 'v${{ env.TOOL_VERSION_DENO }}'

# Every leg runs the same suite; the cloudflare one inside workerd
# (vitest-pool-workers).
# (vitest-plugin).
- name: Run test suite under ${{ matrix.runtime }}
if: inputs.run_tests
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/js_sdk_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ jobs:
E2B_API_KEY: ${{ secrets.E2B_API_KEY }}
E2B_DOMAIN: ${{ inputs.E2B_DOMAIN }}

# Full unit + connectionConfig suite inside workerd (vitest-pool-workers).
# Full unit + connectionConfig suite inside workerd (vitest-plugin).
- name: Run test suite under Cloudflare workerd
if: matrix.runtime == 'cloudflare'
run: pnpm test:cf
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"devDependencies": {
"@changesets/cli": "2.31.1",
"@cloudflare/vitest-pool-workers": "^0.23.0",
"@cloudflare/vitest-plugin": "^1.4.11",
"@types/node": "catalog:",
"dotenv": "^16.4.5",
"oxlint": "^1.81.0",
Expand Down
2 changes: 0 additions & 2 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@
"check-deps": "knip"
},
"devDependencies": {
"@types/handlebars": "^4.1.0",
"@types/inquirer": "^9.0.10",
"@types/json2md": "^1.5.4",
"@types/node": "catalog:",
"@types/npmcli__package-json": "^4.0.4",
Expand Down
1 change: 0 additions & 1 deletion packages/code-interpreter-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"format": "prettier --write src/ tests/"
},
"devDependencies": {
"@cloudflare/vitest-pool-workers": "^0.23.0",
"@types/node": "catalog:",
"@typescript/native": "catalog:",
"dotenv": "^16.4.5",
Expand Down
1 change: 0 additions & 1 deletion packages/desktop-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
"format": "prettier --write src/ tests/"
},
"devDependencies": {
"@cloudflare/vitest-pool-workers": "^0.23.0",
"@typescript/native": "catalog:",
"@types/node": "catalog:",
"dotenv": "^16.4.5",
Expand Down
2 changes: 0 additions & 2 deletions packages/js-sdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,10 @@
"format": "prettier --write src/ tests/"
},
"devDependencies": {
"@cloudflare/vitest-pool-workers": "^0.23.0",
"@redocly/cli": "2.71.0",
"@types/node": "catalog:",
"@types/platform": "^1.3.6",
"@typescript/native": "catalog:",
"@vitest/browser": "catalog:",
"@vitest/browser-playwright": "catalog:",
"dotenv": "^16.6.1",
"error-stack-parser-es": "^2.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/js-sdk/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function getRuntime(): { runtime: Runtime; version: string } {
}

// Check the explicit Workers marker before the generic Node check — Node
// compatibility shims (workerd's nodejs_compat, vitest-pool-workers) can
// compatibility shims (workerd's nodejs_compat, vitest-plugin) can
// populate process.release.name inside Workers.
if ((globalThis as any).navigator?.userAgent === 'Cloudflare-Workers') {
return { runtime: 'cloudflare-worker', version: 'unknown' }
Expand Down
2 changes: 1 addition & 1 deletion packages/js-sdk/tests/runtime.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ afterEach(() => {
test.skipIf(!isNodeHost)(
'Cloudflare Workers marker wins over Node-compat process.release',
async () => {
// Workers' nodejs_compat (and vitest-pool-workers) populate
// Workers' nodejs_compat (and vitest-plugin) populate
// process.release.name, so the explicit marker must take precedence.
vi.stubGlobal('navigator', { userAgent: 'Cloudflare-Workers' })

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Deployed to real Cloudflare infrastructure via `pnpm deploy:cf`
// (wrangler deploy --temporary). Imports the built ESM bundle so wrangler's
// bundling and workerd's production module semantics (e.g. import.meta.url
// being undefined, #1579) are exercised — the vitest-pool-workers suite
// being undefined, #1579) are exercised — the vitest-plugin suite
// polyfills those away.
import { Sandbox } from '../../../dist/index.mjs'

Expand Down
Loading
Loading