Skip to content

chore(deps): drop unused devDependencies and migrate to @cloudflare/vitest-plugin - #2079

Merged
mishushakov merged 1 commit into
mainfrom
devin/1793632631-drop-unused-devdeps
Nov 2, 2026
Merged

mishushakov merged 1 commit into
mainfrom
devin/1793632631-drop-unused-devdeps

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Dev-only dependency cleanup across the JS packages (no runtime/public surface change, so no changeset).

Migrate @cloudflare/vitest-pool-workers → @cloudflare/vitest-plugin. The old package is deprecated ("renamed to @cloudflare/vitest-plugin, will not receive future updates"; 0.23.0 was its last release). 1.x is the same package under the new name, with the same exports, including cloudflareTest, so the only code change is the import in the root vitest.cloudflare.config.mts:

-import { cloudflareTest } from '@cloudflare/vitest-pool-workers'
+import { cloudflareTest } from '@cloudflare/vitest-plugin'

Pinned to ^1.4.11 because 1.4.12 and 1.5.0 are still inside the 3-day minimumReleaseAge window. Cloudflare's codemod only rewrites v3-style defineWorkersProject configs, which we don't use. The msw-redirect comment keeps naming vitest-pool-workers, because that's the package that shipped the redirect.

Remove unused devDependencies:

  • js-sdk, code-interpreter-js, desktop-js: @cloudflare/vitest-pool-workers. Only the root vitest.cloudflare.config.mts imports it, and that file resolves it from the root package.json.
  • js-sdk: @vitest/browser. Never imported; @vitest/browser-playwright already depends on it.
  • cli: @types/handlebars, a deprecated empty package (handlebars ships its own types).
  • cli: @types/inquirer, v9 typings for inquirer 12, which ships its own types.

Other packages that knip reports as unused are false positives and are kept:

  • wrangler is run via npx in the cloudflare-deploy setup.
  • undici is loaded with a dynamic import.
  • e2b resolves through tsconfig paths.

Testing

  • pnpm run lint and pnpm run typecheck pass. cli pnpm build works and dist/index.js --version runs.
  • js-sdk test:cf and test:browser run. The only failures are live-API tests that failed the same way before this change (tests/api/list.test.ts, and the httpbin test in tests/sandbox/network.test.ts, where template e2b/httpbin doesn't exist).
  • code-interpreter-js and desktop-js offline Cloudflare tests pass in workerd.

Link to Devin session: https://app.devin.ai/sessions/2b90ec9e7dca45a980d43c513f93b32a
Open in Devin Desktop: https://app.devin.ai/desktop/session/2b90ec9e7dca45a980d43c513f93b32a?variant=devin
Requested by: @mishushakov

…itest-plugin

Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@cla-bot cla-bot Bot added the cla-signed label Nov 2, 2026
@changeset-bot

changeset-bot Bot commented Nov 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c05028f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@linear-code

linear-code Bot commented Nov 2, 2026

Copy link
Copy Markdown

SDK-420

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TASTE.md review: compliant, 0 violations. This PR only changes devDependencies, the lockfile, a test-config import and comments, so no public SDK surface (T-1 through T-74) is touched.

Written by Devin

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Package Artifacts

Built from ce4fb27. Download artifacts from this workflow run.

JS SDK (e2b@2.62.1-devin-1793632631-drop-unused-devdeps.0, with @e2b/dockerfile-utils@0.1.2-devin-1793632631-drop-unused-devdeps.0):

npm install ./e2b-dockerfile-utils-0.1.2-devin-1793632631-drop-unused-devdeps.0.tgz ./e2b-2.62.1-devin-1793632631-drop-unused-devdeps.0.tgz

CLI (@e2b/cli@2.23.1-devin-1793632631-drop-unused-devdeps.0):

npm install ./e2b-cli-2.23.1-devin-1793632631-drop-unused-devdeps.0.tgz

Code Interpreter JS SDK (@e2b/code-interpreter@2.9.1-devin-1793632631-drop-unused-devdeps.0):

npm install ./e2b-code-interpreter-2.9.1-devin-1793632631-drop-unused-devdeps.0.tgz

Desktop JS SDK (@e2b/desktop@2.5.1-devin-1793632631-drop-unused-devdeps.0):

npm install ./e2b-desktop-2.5.1-devin-1793632631-drop-unused-devdeps.0.tgz

Python SDK (e2b==2.62.0+devin.1793632631.drop.unused.devdeps, with e2b-dockerfile-utils==0.1.1+devin.1793632631.drop.unused.devdeps):

pip install ./e2b_dockerfile_utils-0.1.1+devin.1793632631.drop.unused.devdeps-py3-none-any.whl ./e2b-2.62.0+devin.1793632631.drop.unused.devdeps-py3-none-any.whl

Code Interpreter Python SDK (e2b-code-interpreter==2.11.6+devin.1793632631.drop.unused.devdeps):

pip install ./e2b_code_interpreter-2.11.6+devin.1793632631.drop.unused.devdeps-py3-none-any.whl

Desktop Python SDK (e2b-desktop==2.7.2+devin.1793632631.drop.unused.devdeps):

pip install ./e2b_desktop-2.7.2+devin.1793632631.drop.unused.devdeps-py3-none-any.whl

@mishushakov
mishushakov marked this pull request as ready for review November 2, 2026 18:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T18:26:56.817834Z c05028f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@mishushakov
mishushakov enabled auto-merge (squash) November 2, 2026 18:31
@mishushakov
mishushakov merged commit 6c349d9 into main Nov 2, 2026
50 checks passed
@mishushakov
mishushakov deleted the devin/1793632631-drop-unused-devdeps branch November 2, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant