Repository navigation
chore(deps): drop unused devDependencies and migrate to @cloudflare/vitest-plugin - #2079
Conversation
…itest-plugin Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Package ArtifactsBuilt from ce4fb27. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-dockerfile-utils-0.1.2-devin-1793632631-drop-unused-devdeps.0.tgz ./e2b-2.62.1-devin-1793632631-drop-unused-devdeps.0.tgzCLI ( npm install ./e2b-cli-2.23.1-devin-1793632631-drop-unused-devdeps.0.tgzCode Interpreter JS SDK ( npm install ./e2b-code-interpreter-2.9.1-devin-1793632631-drop-unused-devdeps.0.tgzDesktop JS SDK ( npm install ./e2b-desktop-2.5.1-devin-1793632631-drop-unused-devdeps.0.tgzPython SDK ( pip install ./e2b_dockerfile_utils-0.1.1+devin.1793632631.drop.unused.devdeps-py3-none-any.whl ./e2b-2.62.0+devin.1793632631.drop.unused.devdeps-py3-none-any.whlCode Interpreter Python SDK ( pip install ./e2b_code_interpreter-2.11.6+devin.1793632631.drop.unused.devdeps-py3-none-any.whlDesktop Python SDK ( pip install ./e2b_desktop-2.7.2+devin.1793632631.drop.unused.devdeps-py3-none-any.whl |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Dev-only dependency cleanup across the JS packages (no runtime/public surface change, so no changeset).
Migrate
@cloudflare/vitest-pool-workers→@cloudflare/vitest-plugin. The old package is deprecated ("renamed to @cloudflare/vitest-plugin, will not receive future updates"; 0.23.0 was its last release). 1.x is the same package under the new name, with the same exports, includingcloudflareTest, so the only code change is the import in the rootvitest.cloudflare.config.mts:Pinned to
^1.4.11because 1.4.12 and 1.5.0 are still inside the 3-dayminimumReleaseAgewindow. Cloudflare's codemod only rewrites v3-styledefineWorkersProjectconfigs, which we don't use. The msw-redirect comment keeps namingvitest-pool-workers, because that's the package that shipped the redirect.Remove unused devDependencies:
@cloudflare/vitest-pool-workers. Only the rootvitest.cloudflare.config.mtsimports it, and that file resolves it from the rootpackage.json.@vitest/browser. Never imported;@vitest/browser-playwrightalready depends on it.@types/handlebars, a deprecated empty package (handlebarsships its own types).@types/inquirer, v9 typings forinquirer12, which ships its own types.Other packages that knip reports as unused are false positives and are kept:
wrangleris run vianpxin the cloudflare-deploy setup.undiciis loaded with a dynamic import.e2bresolves through tsconfigpaths.Testing
pnpm run lintandpnpm run typecheckpass. clipnpm buildworks anddist/index.js --versionruns.test:cfandtest:browserrun. The only failures are live-API tests that failed the same way before this change (tests/api/list.test.ts, and the httpbin test intests/sandbox/network.test.ts, where templatee2b/httpbindoesn't exist).Link to Devin session: https://app.devin.ai/sessions/2b90ec9e7dca45a980d43c513f93b32a
Open in Devin Desktop: https://app.devin.ai/desktop/session/2b90ec9e7dca45a980d43c513f93b32a?variant=devin
Requested by: @mishushakov