Conversation
pum1k
added this pull request to stack #138
September 14, 2026 09:08
Creating mrs_lib::coro::Task that returned std::expected caused wrong overload selection when comparing coroutine handle with nullptr. This fixes these issues by using the operator bool instead of comparing with nullptr.
pum1k
force-pushed
the
pum1k/fix/coro-expected-compatibility
branch
from
September 14, 2026 09:09
09d3c22 to
597333e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating mrs_lib::coro::Task that returned std::expected caused wrong overload selection when comparing coroutine handle with nullptr. This fixes these issues by using the operator bool instead of comparing with nullptr.