[v6] #143 - Narrow nullable native types, improve PHPStan level to 8

[njoubert-cleverage]

Description

Refs #143. To be merged for v6.0 only (breaking change): this PR is a draft, attached to the v6.0 milestone. It must be released together with cleverage/archive-process-bundle (see the linked PR below).

Step 3 of #143: the 16 remaining level 8 errors all come from native nullable types that are never null in practice. PHPStan keeps the null of the native type even with a stricter PHPDoc, so the native types are narrowed:

• AbstractConfigurableTask::getOptions(): array (was ?array): options are always resolved when read;
• ProcessState::getContextualizedOptions(): array (was ?array): always computed when read;
• CsvResource::$lineNumber is an int (was ?int, initialized to 1);
• ProcessHistory::$startDate is a \DateTimeInterface (was nullable, set in the constructor).

phpstan.neon goes from level 7 to level 8 (no ignore). Levels 9 and 10 are out of scope of this PR.

PHPStan (level 8, no ignore), PHPUnit, PHP-CS-Fixer and Rector pass.

Linked PR

• cleverage/process-bundle#143 - ZipTask and UnzipTask: compatibility with process-bundle v6.0 archive-process-bundle#24: UnzipTask and ZipTask override getOptions(): ?array, which is a fatal error with this PR. The corrective PR (milestone v2.3) declares an array return type, compatible with both process-bundle v5 and v6: archive v2.3 must be released before process-bundle v6.0.

Requirements

• Documentation updates
  • Reference
  • Cookbooks (custom tasks: getOptions() overrides must return an array)
  • Changelog
• Unit tests (no behaviour change, covered by the existing tests)

Breaking changes

• major: overrides of AbstractConfigurableTask::getOptions() declaring a ?array return type, or of ProcessState::getContextualizedOptions(), fail with a fatal error; they must declare array.
• major: subclasses redeclaring CsvResource::$lineNumber or ProcessHistory::$startDate with a nullable type fail with a fatal error.

🤖 Generated with Claude Code