#143 - Type the remaining untyped task options

[njoubert-cleverage]

Description

Refs #143. Follow-up of the PHPStan level 9/10 analysis (see #253): typing these options does not need v6.0, as no value that works today is rejected.

Task options declared without type validation (the other ones were typed in #228; mode is already typed in AbstractCsvTask):

• split_character of CsvWriterTask and SplitJoinLineTask: setAllowedTypes(['string']). A wrong type used to fail later with a TypeError (implode() / explode() under strict_types), it is now an InvalidOptionsException when the options are resolved;
• write_headers of CsvWriterTask and log_empty_lines of CsvReaderTask: cast to bool by a normalizer. They are only read in a condition, so any value (1, 0, 'yes'…) used to be evaluated as a boolean: it is cast instead of being rejected, to keep it working.

Tests added in OptionAllowedTypesTest (invalid and valid split_character, bool cast of write_headers and log_empty_lines). On main, the 6 new cases fail. PHPStan, PHPUnit (846 tests), PHP-CS-Fixer and Rector pass.

Requirements

• Documentation updates
  • Reference
  • Cookbooks
  • Changelog
• Unit tests

Breaking changes

None: a non-string split_character already failed (later, with a TypeError), and boolean options accept any value as before.

🤖 Generated with Claude Code