Repository navigation
Conversation
Closed
viridia
approved these changes
Oct 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
FeathersColorInputclaim that user preferences are saved, but this is not actually implemented #26067.Solution
bevy-settingsand connectsColorInputSettingsto Bevy's settings system, so apps can save and restore the selected mode and recent colors. To make this work, apps need to addSettingsPluginand trigger a save.bevy-settingsa direct dependency ofbevy_feathers. If there's a preferred way to handle this dependency, I'm happy to adjust.Testing
AI Disclosure
bevy_settingsworks so I could integrate it withColorInputSettings. AI also assisted with reviewing the code, while I manually implemented the changes and tested saving and loading the settings.