Repository navigation
Fix color input docs - #26071
Fix color input docs#26071sri443 wants to merge 1 commit into
Conversation
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
|
Ah yes. I was saving this for the very last thing, or a follow-up PR, and I guess it slipped my mind. To save the user preferences, three things have to happen:
Note that doing this means that the app developer has no control over which TOML key is used to store the color input preferences, since it's hard-coded in the derive macro. This is probably OK. Changing the documentation works, but you'll just have to change it back again once settings are implemented. |
|
@viridia Thanks for explaining! I thought of doing the full fix too, but figured updating the docs in the meantime would be better than leaving something misleading in there. I understand the docs would need to be updated again once the settings work is done. Is anyone already working on the full settings fix? If not, I'm happy to take it on! Otherwise, would the docs-only change be fine to merge for now? |
|
Nope, no one is working on this. |
|
Great! then i'll give it a try. |
Objective
FeathersColorInputclaim that user preferences are saved, but this is not actually implemented #26067.Solution
Testing
AI Disclosure