Skip to content

fix: resolve P0 dependency issues from audit #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beeeku merged 1 commit into from
Mar 20, 2026
Merged

fix: resolve P0 dependency issues from audit #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 15 additions & 21 deletions e2e/dependency-audit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
import { describe, it, expect } from 'vitest'
import { readFileSync } from 'fs'
import { fileURLToPath } from 'url'
import path from 'path'

const __dirname = path.dirname(fileURLToPath(import.meta.url))

function readPkg(relPath: string) {
const full = path.resolve(__dirname, '..', relPath, 'package.json')
return JSON.parse(readFileSync(full, 'utf-8'))
Expand All @@ -21,47 +24,38 @@ describe('P0 dependency audit', () => {
})

describe('unused runtime dependencies are removed', () => {
it('@workkit/cache has no @workkit/types in dependencies', () => {
it('@workkit/cache has no @workkit/types or @workkit/errors in dependencies', () => {
const pkg = readPkg('packages/cache')
expect(pkg.dependencies ?? {}).not.toHaveProperty('@workkit/types')
})

it('@workkit/cache has no @workkit/errors in dependencies', () => {
const pkg = readPkg('packages/cache')
expect(pkg.dependencies ?? {}).not.toHaveProperty('@workkit/errors')
})

it('@workkit/crypto has no @workkit/types in dependencies', () => {
it('@workkit/crypto has no @workkit/types or @workkit/errors in dependencies', () => {
const pkg = readPkg('packages/crypto')
expect(pkg.dependencies ?? {}).not.toHaveProperty('@workkit/types')
})

it('@workkit/crypto has no @workkit/errors in dependencies', () => {
const pkg = readPkg('packages/crypto')
expect(pkg.dependencies ?? {}).not.toHaveProperty('@workkit/errors')
})
})

describe('CLI template deps are in devDependencies, not dependencies', () => {
const templateDeps = ['@workkit/types', '@workkit/errors', '@workkit/env', '@workkit/d1']
describe('CLI external deps are in dependencies for runtime resolution', () => {
const externalDeps = ['@workkit/types', '@workkit/errors', '@workkit/env', '@workkit/d1']

for (const dep of templateDeps) {
it(`workkit CLI has ${dep} in devDependencies, not dependencies`, () => {
for (const dep of externalDeps) {
it(`workkit CLI has ${dep} in dependencies`, () => {
const pkg = readPkg('packages/cli')
expect(pkg.dependencies ?? {}).not.toHaveProperty(dep)
expect(pkg.devDependencies).toHaveProperty(dep)
expect(pkg.dependencies).toHaveProperty(dep)
})
}
})

describe('@standard-schema/spec is a peerDep in remix, not a dep', () => {
it('@workkit/remix has @standard-schema/spec in peerDependencies', () => {
const pkg = readPkg('integrations/remix')
describe('@standard-schema/spec in remix', () => {
const pkg = readPkg('integrations/remix')

it('is in peerDependencies', () => {
expect(pkg.peerDependencies).toHaveProperty('@standard-schema/spec')
})

it('@workkit/remix does not have @standard-schema/spec in dependencies', () => {
const pkg = readPkg('integrations/remix')
it('is not in runtime dependencies', () => {
expect(pkg.dependencies ?? {}).not.toHaveProperty('@standard-schema/spec')
})
})
Expand Down
Loading