Skip to content

fix: resolve P0 dependency issues from audit - #4

Merged
beeeku merged 1 commit into
masterfrom
fix/p0-dependency-cleanup
Mar 20, 2026
Merged

beeeku merged 1 commit into
masterfrom
fix/p0-dependency-cleanup

Conversation

@beeeku

@beeeku beeeku commented Mar 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add @standard-schema/spec to @workkit/astro devDependencies (used in tests/helpers.ts)
  • Add zod to @workkit/hono devDependencies (used in tests/middleware.test.ts)
  • Remove unused @workkit/types and @workkit/errors from @workkit/cache dependencies
  • Remove unused @workkit/types and @workkit/errors from @workkit/crypto dependencies
  • Move CLI template deps (@workkit/types, @workkit/errors, @workkit/env, @workkit/d1) to devDependencies (only used in codegen string templates)
  • Move @standard-schema/spec from dependencies to peerDependencies in @workkit/remix (type-only import)
  • Hoist shared devDependencies (typescript, vitest, bunup, @cloudflare/workers-types) to root workspace
  • Add e2e dependency audit test to prevent regression (12 assertions)

Test plan

  • bun run typecheck passes (25/25 tasks)
  • bun run build passes (21/21 tasks)
  • bun run test passes (21/21 tasks)
  • New e2e/dependency-audit.test.ts validates all 12 dependency constraints

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Mar 20, 2026 •

Copy link
Copy Markdown
Contributor

Bundle Size Report

Package Base PR Delta
@workkit/ai 43KiB 43KiB no change
@workkit/ai-gateway 56KiB 56KiB no change
@workkit/api 82KiB 82KiB no change
@workkit/astro 18KiB 18KiB no change
@workkit/auth 48KiB 48KiB no change
@workkit/cache 38KiB 38KiB no change
@workkit/cli 107KiB 107KiB no change
@workkit/cron 49KiB 49KiB no change
@workkit/crypto 26KiB 26KiB no change
@workkit/d1 90KiB 90KiB no change
@workkit/do 26KiB 26KiB no change
@workkit/env 43KiB 43KiB no change
@workkit/errors 40KiB 40KiB no change
@workkit/hono 25KiB 25KiB no change
@workkit/kv 33KiB 33KiB no change
@workkit/queue 21KiB 21KiB no change
@workkit/r2 57KiB 57KiB no change
@workkit/ratelimit 32KiB 32KiB no change
@workkit/remix 34KiB 34KiB no change
@workkit/testing 102KiB 102KiB no change
@workkit/types 19KiB 19KiB no change

@coderabbitai

coderabbitai Bot commented Mar 20, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@beeeku has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 86f9c3f2-91aa-4675-a1ed-7ad569775409

📥 Commits

Reviewing files that changed from the base of the PR and between 9fb600b and cde330b.

📒 Files selected for processing (1)
  • e2e/dependency-audit.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/p0-dependency-cleanup

Comment @coderabbitai help to get the list of available commands and usage tips.

@beeeku
beeeku force-pushed the fix/p0-dependency-cleanup branch from e427b99 to f8c8a8c Compare March 20, 2026 18:46
- Use import.meta.url instead of __dirname for ESM compatibility
- Consolidate readPkg calls — one per package, multiple assertions
- Update CLI test to verify deps are in dependencies (not devDeps)
  since they are external and needed at runtime

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@beeeku
beeeku force-pushed the fix/p0-dependency-cleanup branch from f8c8a8c to cde330b Compare March 20, 2026 18:50
@beeeku
beeeku merged commit 8581f51 into master Mar 20, 2026
7 checks passed
@beeeku
beeeku deleted the fix/p0-dependency-cleanup branch March 20, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant