Repository navigation
Sync up Github CI YAML with hotfix/3.11.4 ones - #4756
Draft
TranceLove wants to merge 1 commit into
Draft
TranceLove wants to merge 1 commit into
TranceLove wants to merge 1 commit into
Conversation
TranceLove
changed the title
TranceLove
requested review from
EmmanuelMess and
VishnuSanal
and
a balanced review from Copilot
and removed request for
EmmanuelMess
October 23, 2026 10:56
There was a problem hiding this comment.
🟡 Changes recommended
The workflows install an NDK version inconsistent with the project pin, and two formatting jobs reference missing step IDs.
3 open issues
What changed in this PR
Synchronizes Android GitHub Actions workflows with hotfix/3.11.4 to address the CI failures reported on #4713.
Changes:
- Updates NDK and Rust setup and pins selected actions to commit hashes.
- Adds explicit Gradle build commands to artifact workflows and normalizes
assembleDebugspelling. - Adds NDK environment assignments to formatting jobs.
| File | Description |
|---|---|
.github/workflows/android-main.yml |
Updates toolchains and formatting-step NDK environment. |
.github/workflows/android-feature.yml |
Adds build NDK setup and normalizes the build command. |
.github/workflows/android-emulator-ondemand.yml |
Adds NDK setup and updates Rust for emulator builds. |
.github/workflows/android-debug-artifact-release.yml |
Updates toolchains and explicitly runs the artifact build. |
.github/workflows/android-debug-artifact-ondemand.yml |
Pins actions, updates toolchains, and explicitly runs the build. |
.github/workflows/android-build.yml |
Updates toolchains, formatting environment, and build invocation. |
Review effort: Balanced
| uses: nttld/setup-ndk@ed92fe6cadad69be94a966a7ee3271275e62f779 | ||
| with: | ||
| toolchain: stable | ||
| ndk-version: r30 |
Member
|
Please only minimal changes to hotfix. |
TranceLove
force-pushed
the
bugfix/align-github-ci-yaml
branch
2 times, most recently
from
October 24, 2026 01:04
cf91759 to
e9103cb
Compare
TranceLove
force-pushed
the
bugfix/align-github-ci-yaml
branch
from
October 24, 2026 01:16
e9103cb to
dca39bf
Compare
EmmanuelMess
marked this pull request as draft
October 25, 2026 13:16
Member
|
Okay, this might not be needed anymore since I remerged 3.11.3? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue tracker
Addresses Github CI failures at #4713, by syncing Github CI YAML files used since
hotfix/3.11.4.Manual tests
Done
Device:
OS:
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheckGenerative code
No AI tools or models are involved on creation of this PR.