Sync up Github CI YAML with hotfix/3.11.4 ones

Author: EmmanuelMess

.github/workflows/android-build.yml

@@ -22,15 +22,13 @@ jobs:
           distribution: "temurin"
           java-version: 17
       - name: Set up NDK
-        uses: nttld/setup-ndk@v1
+        id: setup-ndk
+        uses: nttld/setup-ndk@ed92fe6cadad69be94a966a7ee3271275e62f779
         with:
           ndk-version: r28c
           link-to-sdk: true
-          local-cache: true
       - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
-        with:
-          toolchain: stable
+        uses: dtolnay/rust-toolchain@1.98.1
       - name: Cache Rust dependencies
         uses: actions/cache@v5
         with:
@@ -63,6 +61,8 @@ jobs:
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v6
       - name: Check formatting using spotless
+        env:
+          ANDROID_NDK_HOME: ${{ steps.setup-ndk.outputs.ndk-path }}
         run: ./gradlew spotlessCheck --stacktrace
 
   build:
@@ -75,10 +75,13 @@ jobs:
         with:
           distribution: "temurin"
           java-version: 17
-      - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+      - name: Set up NDK
+        uses: nttld/setup-ndk@ed92fe6cadad69be94a966a7ee3271275e62f779
         with:
-          toolchain: stable
+          ndk-version: r30
+          link-to-sdk: true
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@1.98.1
       - name: Cache Rust dependencies
         uses: actions/cache@v5
         with:
@@ -111,4 +114,4 @@ jobs:
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v6
       - name: Build with Gradle
-        run: ./gradlew assembledebug --stacktrace
+        run: ./gradlew assembleDebug --stacktrace

.github/workflows/android-debug-artifact-ondemand.yml

@@ -18,7 +18,7 @@ jobs:
           reactions: '+1'
       - name: Github API Request
         id: request
-        uses: octokit/request-action@v3
+        uses: octokit/request-action@b91aabaa861c777dcdb14e2387e30eddf04619ae
         with:
           route: ${{ github.event.issue.pull_request.url }}
         env:
@@ -41,13 +41,12 @@ jobs:
           distribution: "temurin"
           java-version: 17
       - name: Set up NDK
-        uses: nttld/setup-ndk@v1
+        uses: nttld/setup-ndk@ed92fe6cadad69be94a966a7ee3271275e62f779
         with:
           ndk-version: r28c
           link-to-sdk: true
-          local-cache: true
       - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@1.98.1
         with:
           toolchain: stable
       - name: Cache Rust dependencies
@@ -79,10 +78,10 @@ jobs:
             echo "❌ .cargo/config.toml missing"
             exit 1
           fi
-      - name: Build with Gradle
+      - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v6
-        with:
-          arguments: assembleDebug --stacktrace
+      - name: Build with Gradle
+        run: ./gradlew assembleDebug --stacktrace
       - name: Upload fdroid artifact
         uses: actions/upload-artifact@v7
         id: artifact-upload-fdroid
@@ -105,7 +104,7 @@ jobs:
           echo "PR_Number: $PR_NUMBER"
           echo "PR_NUMBER=$PR_NUMBER" >> "$GITHUB_OUTPUT"
       - name: Notify the user with a comment once the APK is uploaded
-        uses: peter-evans/create-or-update-comment@v5
+        uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9
         with:
           issue-number: ${{ steps.find-pr-id.outputs.PR_NUMBER }}
           body: |

.github/workflows/android-debug-artifact-release.yml

@@ -15,11 +15,10 @@ jobs:
           distribution: "temurin"
           java-version: 17
       - name: Set up NDK
-        uses: nttld/setup-ndk@v1
+        uses: nttld/setup-ndk@ed92fe6cadad69be94a966a7ee3271275e62f779
         with:
           ndk-version: r28c
           link-to-sdk: true
-          local-cache: true
       - name: Install Rust
         uses: dtolnay/rust-toolchain@stable
         with:
@@ -53,10 +52,10 @@ jobs:
             echo "❌ .cargo/config.toml missing"
             exit 1
           fi
-      - name: Build with Gradle
+      - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v6
-        with:
-          arguments: assembleDebug
+      - name: Build with Gradle
+        run: ./gradlew assembleDebug --stacktrace
       - name: Upload fdroid artifact
         uses: actions/upload-artifact@v7
         with:

.github/workflows/android-emulator-ondemand.yml

@@ -32,10 +32,13 @@ jobs:
         with:
           distribution: "temurin"
           java-version: 17
-      - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+      - name: Set up NDK
+        uses: nttld/setup-ndk@ed92fe6cadad69be94a966a7ee3271275e62f779
         with:
-          toolchain: stable
+          ndk-version: r30
+          link-to-sdk: true
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@1.98.1
       - name: Cache Rust dependencies
         uses: actions/cache@v5
         with:

.github/workflows/android-feature.yml

@@ -24,11 +24,10 @@ jobs:
           java-version: 17
       - name: Set up NDK
         id: setup-ndk
-        uses: nttld/setup-ndk@v1
+        uses: nttld/setup-ndk@ed92fe6cadad69be94a966a7ee3271275e62f779
         with:
           ndk-version: r28c
           link-to-sdk: true
-          local-cache: true
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v6
       - name: Check formatting using spotless
@@ -46,10 +45,13 @@ jobs:
         with:
           distribution: "temurin"
           java-version: 17
-      - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+      - name: Set up NDK
+        uses: nttld/setup-ndk@ed92fe6cadad69be94a966a7ee3271275e62f779
         with:
-          toolchain: stable
+          ndk-version: r28c
+          link-to-sdk: true
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@1.98.1
       - name: Cache Rust dependencies
         uses: actions/cache@v5
         with:
@@ -82,6 +84,6 @@ jobs:
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v6
       - name: Build with Gradle
-        run: ./gradlew assembledebug --stacktrace
+        run: ./gradlew assembleDebug --stacktrace
       - name: Run test cases
-        run: ./gradlew jacocoTestPlayDebugUnitTestReport --stacktrace --info
+        run: ./gradlew jacocoTestPlayDebugUnitTestReport --stacktrace --info

.github/workflows/android-main.yml

@@ -23,14 +23,16 @@ jobs:
           distribution: "temurin"
           java-version: 17
       - name: Set up NDK
-        uses: nttld/setup-ndk@v1
+        id: setup-ndk
+        uses: nttld/setup-ndk@ed92fe6cadad69be94a966a7ee3271275e62f779
         with:
           ndk-version: r28c
           link-to-sdk: true
-          local-cache: true
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v6
       - name: Check formatting using spotless
+        env:
+          ANDROID_NDK_HOME: ${{ steps.setup-ndk.outputs.ndk-path }}
         run: ./gradlew spotlessCheck
 
   build:
@@ -46,9 +48,7 @@ jobs:
           distribution: "temurin"
           java-version: 17
       - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
-        with:
-          toolchain: stable
+        uses: dtolnay/rust-toolchain@1.98.1
       - name: Cache Rust dependencies
         uses: actions/cache@v5
         with:
@@ -114,9 +114,7 @@ jobs:
           distribution: "temurin"
           java-version: 17
       - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
-        with:
-          toolchain: stable
+        uses: dtolnay/rust-toolchain@1.98.1
       - name: Cache Rust dependencies
         uses: actions/cache@v5
         with:

app/src/main/java/com/amaze/filemanager/filesystem/HybridFile.java

@@ -1117,7 +1117,7 @@ public void close() throws IOException {
                           LOG.debug("Closing input stream for {}", getPath());
                           super.close();
                         } catch (Throwable e) {
-                          e.printStackTrace();
+                          LOG.error("Error closing input stream for {}", getPath(), e);
                         } finally {
                           LOG.debug("Closing client for {}", getPath());
                           rf.close();