[3.0] Put the admin search box back beside its heading, not in front of it

[albertlast]

Description

Every admin page carries a bar holding the quick search form and the heading for the page. The form comes first in the markup, and .admin_search carries float: right, so the heading sat on the left and the search box on the right.

b81b1fa (#9390) made div.cat_bar a flex row so a sibling could sit beside the heading. A float is ignored on a flex item, so the two now come out in source order, and the search box has been sitting on the left with the heading pushed over beside it. That was an unintended side effect of #9390 — mine — and this puts it right.

Putting the heading first restores the old layout, this time through the rule the other bars already use:

div.cat_bar > h3,
div.title_bar > h3,
div.title_bar > h4 {
	flex: 1;
}

Two places emit that bar and both needed the same change:

• template_generic_menu_tabs() in GenericMenu.template.php — every admin page
• template_admin_search_results() in Admin.template.php — the results page, which builds a bar of its own

It reads better in that order anyway: the heading says what the page is before the control that changes it.

Verification

Each page loaded in a 1200px frame, measuring getBoundingClientRect() on the bar and its two children.

page	heading x →	search form x →
area=admin	396 → 72	72 → 786
area=manageboards	396 → 72	72 → 786
area=permissions	396 → 72	72 → 786
area=maintain	396 → 72	72 → 786
area=viewmembers	396 → 72	72 → 800
area=search (results)	382 → 58	58 → 528

The bar box itself is unchanged throughout — 1038–1052px wide, 35px tall — so only the two children swap ends.

float: right on .admin_search is inert now rather than wrong, so it is left alone — it would matter again if that bar ever stopped being a flex row.

Issues References (Fixes|Related|Closes)

Related: #9390, #7933