[3.0] Theme split (wave 4, part 20) — read out the page links before the buttons beside them - #9445
Merged
live627 merged 1 commit intoAug 10, 2026
Conversation
A .pagesection holds the page links and a row of buttons, one floated to each side. The markup put the buttons first, so anything reading the page in source order - a screen reader, or the tab key - met them before the page links they sit next to, which is the opposite of what is on screen. The message index is the clearest case: it draws a .pagesection above the topic list and another below it, and the two disagreed. The top one already put the page links first; only the bottom one was the other way round. Both are floated and .pagesection is a plain block, so the rendering does not move. Measured on the message index, where both sections are visible at once: page links at x=72 and the button strip at x=709 before and after, in both sections. Same on the memberlist. Only the order in the document changes. Signed-off-by: Mathias Alberts <mathiaspapealbert@hotmail.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
albertlast
force-pushed
the
3.0/pagesection-order
branch
from
August 9, 2026 14:54
291bcb3 to
9f2c40f
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A
.pagesectionholds the page links and a row of buttons, one floated to each side. The markup put the buttons first, so anything reading the page in source order — a screen reader, or the tab key — met them before the page links they sit next to, which is the opposite of what is on screen.The message index is the clearest case, because it draws a
.pagesectionabove the topic list and another below it, and the two disagreed. The top one already put the page links first; only the bottom one was the other way round.Verification
.pagesectionis a plaindisplay: blockand both children are really floated, so nothing moves. Measured on the message index, where both sections are visible at once:Only the DOM order changes — the bottom section goes from
buttonlist | pagelinks | mobile_buttonstopagelinks | buttonlist | mobile_buttons, matching the top one.Covers the memberlist, the two sections on
?action=moderate;area=postmod, and the message index. The quick-moderation variant of the moderation-centre section could not be exercised on the test install.I checked that this is genuinely a no-op before claiming it, because it is not always:
.cat_barbecame a flex row in #9390, and a float is ignored on a flex item, so the same-looking reorder there does move things (see #9449)..pagesectionis still a block, so it does not.Issues References (Fixes|Related|Closes)
Related: #7933