Repository navigation
fix(tmdb): match the TMDB linking to the server - #1485
Merged
Merged
Conversation
revam
added this pull request to stack #1490
October 3, 2026 17:38
harshithmohan
force-pushed
the
split/08-tmdb-linking
branch
from
October 3, 2026 17:43
ecd0a42 to
4d07d8f
Compare
revam
force-pushed
the
split/08-tmdb-linking
branch
from
October 3, 2026 18:48
4d07d8f to
f925150
Compare
harshithmohan
force-pushed
the
split/08-tmdb-linking
branch
3 times, most recently
from
October 4, 2026 08:00
3f50dc9 to
623b509
Compare
harshithmohan
force-pushed
the
split/08-tmdb-linking
branch
from
October 5, 2026 17:38
623b509 to
eb5c1a3
Compare
harshithmohan
removed this pull request from stack #1490
October 5, 2026 17:42
harshithmohan
added this pull request to stack #1492
October 5, 2026 17:42
- The auto search preview lists a candidate once per origin; each entry is now listed once, with a badge for every origin that found it - Episode links rated `DateAndNumberMatches` or `DateOffsetMatches` showed a blank badge and were left out of the counts - The episode mapping body sent `ResetAll`, which the server never read; it is `UnsetAll` now - A suggestion the automatic search would not link shows the server's `Rejection` as a badge, with its details in a tooltip; it can still be picked. The badge is a warning, except for an existing link or an unneeded hint, which only give context
harshithmohan
force-pushed
the
split/08-tmdb-linking
branch
from
October 6, 2026 13:50
eb5c1a3 to
fa2b4d8
Compare
harshithmohan
removed this pull request from stack #1492
October 6, 2026 13:53
harshithmohan
changed the base branch from
split/07-scheduled-actions
to
master
October 6, 2026 13:53
harshithmohan
added this pull request to stack #1494
October 6, 2026 13:53
harshithmohan
removed this pull request from stack #1494
October 6, 2026 13:54
harshithmohan
added this pull request to stack #1495
October 6, 2026 13:55
harshithmohan
removed this pull request from stack #1495
October 6, 2026 16:37
harshithmohan
added this pull request to stack #1496
October 6, 2026 16:37
Keeps the per-origin dedup/grouping and badges from #1485, but removes the Rejection reason mapping, tooltip, and badge — flagged as too much inline data-translation logic for a presentational row component. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codifies when a presentational child component defined alongside its parent should be split into its own file, prompted by review feedback on the TMDB rejection-badge removal in this PR.
hidden4003
approved these changes
Oct 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The server's TMDB auto-search preview now returns one entry per origin with a
Rejection, and the episode mapping readsUnsetAll. The linking page didn't follow.What changed
Rejectionas a badge with a tooltip; it can still be picked by hand. The badge is a warning, except for an existing link or an unneeded hint, which only give context.DateAndNumberMatchesandDateOffsetMatchesget a badge and count.UnsetAllinstead ofResetAll, which the server never read.Where to look first
src/components/Collection/Tmdb/TmdbLinkSelectPanel.tsx: grouping by candidate and the badges.Feedback wanted
Whether the rejection badges and tooltips explain enough.
Stack
Part 8 of 12 in the split of #1477. Below: Part 7, the scheduled actions page. Above: Part 9, linking any metadata source.
Testing
pnpm tscheck,pnpm lint,pnpm testandpnpm buildpass at this branch's tip. Manual, on 6.0.0-dev.495: open the TMDB linking page for a series with several suggestions; each shows once, with its origins.