Repository navigation
Staging - #1503
Merged
Merged
Staging#1503
Conversation
* fix(tmdb): match the TMDB linking to the server - The auto search preview lists a candidate once per origin; each entry is now listed once, with a badge for every origin that found it - Episode links rated `DateAndNumberMatches` or `DateOffsetMatches` showed a blank badge and were left out of the counts - The episode mapping body sent `ResetAll`, which the server never read; it is `UnsetAll` now - A suggestion the automatic search would not link shows the server's `Rejection` as a badge, with its details in a tooltip; it can still be picked. The badge is a warning, except for an existing link or an unneeded hint, which only give context * fix(tmdb): drop rejection badge/tooltip from TMDB link select panel Keeps the per-origin dedup/grouping and badges from #1485, but removes the Rejection reason mapping, tooltip, and badge — flagged as too much inline data-translation logic for a presentational row component. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * docs(agents): add inline component complexity guideline Codifies when a presentational child component defined alongside its parent should be split into its own file, prompted by review feedback on the TMDB rejection-badge removal in this PR. --------- Co-authored-by: hidden4003 <hidden4003@users.noreply.github.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
…ource
- Moved search, the auto-search preview, series and movie linking and unlinking, and the cross-reference listing onto the `Metadata/` and `Series/{id}/Metadata/{source}` routes
- Added a source picker fed by `GET Metadata/Source`; the page is at `metadata-linking?source=`, with `tmdb-linking` kept and TMDB as the default
- Moved the ordering choice onto `Metadata/{source}/Series/{id}/Orderings` and its `SetPreferred`, for every source
- Moved the episode mapping onto `Series/{id}/Metadata/{source}/CrossReferences/Episode` (and `…/Auto`), `Metadata/{source}/Series/{id}/Episode` and `Metadata/{source}/Episode/Bulk`, with string IDs, shown for every linked series that has episodes
- Searched episodes by season, special or title (`S1E5`, `Special 3`) in the episode picker
- Moved the linking components, which serve every source now, from `Collection/Tmdb/` to `Collection/MetadataLinking/`
- Removed the TMDB episode hooks and types it replaced
feat(metadata): link series and map their episodes for any metadata source
- Listed the series' links to every source after AniDB and TMDB, from `IDs.Linked`, with `Series/{id}/Metadata/{source}/CrossReferences` telling series from movies
- Added a row to link each source `GET Metadata/Source` reports enabled
- Opened other sources' entries on the linking page, as the server sends no site URL for them; TMDB keeps its external link
- Renamed `SeriesMetadata` to `SeriesMetadataLink`, which takes a `source` and its `sourceName`
The cross-references query is disabled once a source has no linked IDs, and invalidating skips disabled queries, so the removed row kept rendering from the cache.
The linking page falls back to TMDB for a source the server does not list, so a link to such a source opened the wrong page. Show those links without the linking page link or the actions.
Before the sources load, a linked source cannot be told from an unlisted one, so every one showed read-only and then switched.
feat(series): list links to every metadata source
- Linked search, suggestion and cross-reference rows and the linking page header through the server's `SiteUrl`, for every source - Listed TMDB's links on the series page from `…/CrossReferences` like the other sources, falling back to the linking page without a `SiteUrl` - Removed the TMDB URL builders and `getSiteLink`
- Added `MetadataSourceIcon`, loading `Metadata/Source/{source}/Icon` when the source `HasIcon`, else the database icon
- Used it on the series page's links and the linking page's source label
- Dropped the bundled TMDB image; AniDB's stays for AniDB IDs shown elsewhere
- Replaced the series page's add row per source with one "Add link" button, which opens the linking page without a source - Listed the linkable sources there with their icon and a hint, going straight to the only one when there is one, and replacing the history entry on a pick - Removed the source dropdown from the search panel; edit links keep naming their source - Removed the `tmdb-linking` route
…llow-ups refactor(metadata): add source site links and icons, pick the source on the linking page
- Renamed the TMDB tab to Metadata, listing each source from `GET Metadata/Provider` with its icon and status from `GET Metadata/Source`, and its icon from the providers' `HasIcon` when the source list has none
- Set every kind through `PUT Metadata/Source/{source}/Providers`: a switch where one provider answers, an order where several do, the answering provider marked Active and the other enabled ones Standby; `PUT Metadata/Provider/{providerID}` stays for auto-linking
- Moved the auto-linker and the auto-link switches onto the provider route for every source, and added TMDB's network download switch
- Kept the switches, orders and auto-link choices as a draft, counted as unsaved changes, sent on Save after the settings `PATCH` and dropped by Cancel; a part that fails stays in the draft with the server's error
- Rendered a provider's own `Configuration` inline in its source's section with `DynamicForm`, saved with its own button through `PUT Configuration/{id}`
- Replaced TMDB's image switches, counts and language order with `Image.MetadataSourceDefaults`, adding banners, and let each source with an image provider keep its own in `Image.MetadataSources`; a picked image language stays unsaved until Save
- Replaced the first run's TMDB tab with a Metadata tab showing the page's search option, image options and sources, its provider changes sent with the step's settings
- Added the `Metadata` purge days
- Stopped reading the core `TMDB` settings: removed `TMDBDownloadSettings` and the `TMDB` block from the settings types and defaults
- Picked the source on the metadata page and moved the export and import onto `Metadata/{source}/CrossReferences/Export` and `…/Import`
- Filtered the export by the source's own series, episode and movie IDs as text
- Listed what an import added, updated, kept and replaced in its toast
- Removed the `Tmdb/Export` and `Tmdb/Import` calls
- Added `getDistinctPluginName`, matching the one on `feat/calendar` - Showed the plugin name in parentheses after the provider name in the provider rows and configuration headers, and left it out when it repeats the provider's name
- Added "Series Title Source", "Episode Title Source" and "Description Source" after the renamed language orders on the collection page, editing `Language.*SourceOrder` in the settings draft - Offered AniDB and every source from `GET Metadata/Source` in an add picker, each with its icon and name, and kept source names no route lists, `user` among them - Moved the drag-and-drop list behind `LanguageOrderList` into `OrderList`, shared by both
…nder `Metadata` - Read and wrote the image defaults and each source's own image options at `Metadata.SourceDefaults.Images` and `Metadata.Sources`, where the server moved them - Added the episode matching window to the source defaults and as a per-source option next to the images - Dropped a source's entry once it follows the defaults for both
- Dropped `SupportsPausing` and typed `Suspensions` on the source status - Worded each suspension from its kind when it gives no reason
refactor(settings): replace the TMDB tab with settings for every metadata source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
stagingintomasterGeneric metadata source support: linking, display and settings now work for any source the server exposes, not just TMDB. This replaces the TMDB-only paths. 25 commits, 68 files, +3443/−1844.
Revamp by @revam
Features
Metadatasettings tab, which replacesTmdbSettings(27bd799).Refactors
Metadata(9068cfa).Fixes
Follow-up fixes by @hidden4003
Fixes
Refactors / chores
tmdb-linkingroute (c7c2239).The minimum server version (
VITE_MIN_SERVER_VERSION) is raised to 6.0.0-dev.503, so this WebUI build will not work against older servers.Testing
pnpm lintandpnpm testpass.