Skip to content

Logger: benchmark options via C/C++ API - #1600

Merged
mgovers merged 3 commits into
pgm/feature/benchmark-via-c-api-2from
pgm/feature/benchmark-via-c-api-3
Sep 30, 2026
Merged

Logger: benchmark options via C/C++ API#1600
mgovers merged 3 commits into
pgm/feature/benchmark-via-c-api-2from
pgm/feature/benchmark-via-c-api-3

Conversation

@mgovers

@mgovers mgovers commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Step 3 of migrating the benchmark to the C/C++ API.

  • Migrating the main model options.

Explicitly scoped out:

  • Migrating the fictional_grid.hpp: for now, it takes the created core dataset and pushes its buffers to the C++ wrapper dataset.
  • Migrating the report formatting to the benchmark.

@mgovers mgovers self-assigned this Sep 24, 2026
@mgovers
mgovers added this pull request to stack #1601 September 24, 2026 07:35
@mgovers mgovers added the improvement Improvement on internal implementation label Sep 24, 2026
This was referenced Sep 24, 2026
Merged
Merged
@mgovers mgovers changed the title migrate benchmark options Logger: migrate benchmark options Sep 24, 2026
@mgovers mgovers changed the title Logger: migrate benchmark options Logger: benchmark options via C/C++ API Sep 24, 2026
@mgovers
mgovers force-pushed the pgm/feature/benchmark-via-c-api-3 branch 2 times, most recently from 836631c to d7beeb9 Compare September 24, 2026 10:36
@Jerry-Jinfeng-Guo

Jerry-Jinfeng-Guo commented Sep 28, 2026

Copy link
Copy Markdown
Member

Needs formatting.

@mgovers
mgovers force-pushed the pgm/feature/benchmark-via-c-api-3 branch 2 times, most recently from 81c841d to 3777478 Compare September 28, 2026 10:21
@mgovers
mgovers force-pushed the pgm/feature/benchmark-via-c-api-3 branch 2 times, most recently from efb6e61 to d2cb61d Compare September 30, 2026 07:44
@mgovers
mgovers force-pushed the pgm/feature/benchmark-via-c-api-3 branch from d2cb61d to 4a34453 Compare September 30, 2026 07:45
@mgovers
migrate benchmark options
2d92209 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
clang-format
1c46f39 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
minor
f40935b 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
mgovers force-pushed the pgm/feature/benchmark-via-c-api-3 branch from 4a34453 to f40935b Compare September 30, 2026 07:55
@sonarqubecloud

sonarqubecloud Bot commented Sep 30, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mgovers
mgovers merged commit bfe44e1 into pgm/feature/benchmark-via-c-api Sep 30, 2026
34 checks passed
@mgovers
mgovers deleted the pgm/feature/benchmark-via-c-api-3 branch September 30, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo approved these changes
@nitbharambe nitbharambe nitbharambe approved these changes

Assignees

@mgovers mgovers

Labels

improvement Improvement on internal implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgovers @Jerry-Jinfeng-Guo @nitbharambe