Skip to content

Logger: Benchmark full timing via C/C++ API - #1599

Merged
mgovers merged 6 commits into
pgm/feature/benchmark-via-c-apifrom
pgm/feature/benchmark-via-c-api-2
Sep 30, 2026
Merged

Logger: Benchmark full timing via C/C++ API#1599
mgovers merged 6 commits into
pgm/feature/benchmark-via-c-apifrom
pgm/feature/benchmark-via-c-api-2

Conversation

@mgovers

@mgovers mgovers commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Step 2 of migrating the benchmark to the C/C++ API.

  • Migrates the outer timers total and build_model

Explicitly scoped out:

  • Migrating the main model options. (see Logger: benchmark options via C/C++ API #1600)
  • Migrating the fictional_grid.hpp: for now, it takes the created core dataset and pushes its buffers to the C++ wrapper dataset.
  • Migrating the report formatting to the benchmark.

@mgovers mgovers self-assigned this Sep 24, 2026
@mgovers mgovers added the improvement Improvement on internal implementation label Sep 24, 2026
@mgovers mgovers changed the title Pgm/feature/benchmark via c api 2 Logger: Benchmark full timing via C/C++ API Sep 24, 2026
@mgovers
mgovers added this pull request to stack #1601 September 24, 2026 07:35
@mgovers mgovers mentioned this pull request Sep 24, 2026
Merged
4 tasks done
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed Sep 25, 2026
View reviewed changes
Comment thread tests/native_api_tests/test_api_logger.cpp Outdated
Jerry-Jinfeng-Guo
Jerry-Jinfeng-Guo reviewed Sep 25, 2026
View reviewed changes
Comment thread tests/native_api_tests/test_api_logger.cpp
@mgovers
mgovers force-pushed the pgm/feature/benchmark-via-c-api-2 branch from 8d58d21 to 7d19e2e Compare September 28, 2026 09:23
@mgovers
mgovers force-pushed the pgm/feature/benchmark-via-c-api-2 branch from 8720410 to 94b4662 Compare September 29, 2026 11:17
@mgovers
migrate enriched report checks
98cf65d 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix tests
1f18ffc 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
clang-format
7c41c8b 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
minor
75cc165 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
minor
a89d0c6 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
mgovers force-pushed the pgm/feature/benchmark-via-c-api-2 branch from 94b4662 to a89d0c6 Compare September 30, 2026 07:45
@mgovers
clang-format
7e664ee 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@sonarqubecloud

sonarqubecloud Bot commented Sep 30, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mgovers
mgovers merged commit bfe44e1 into pgm/feature/benchmark-via-c-api Sep 30, 2026
34 checks passed
@mgovers
mgovers deleted the pgm/feature/benchmark-via-c-api-2 branch September 30, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo approved these changes
@nitbharambe nitbharambe nitbharambe approved these changes

Assignees

@mgovers mgovers

Labels

improvement Improvement on internal implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgovers @Jerry-Jinfeng-Guo @nitbharambe